1323155 - Data race in reading mCompletionPromise

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

thenValue->mCompletionPromise [1] might be changed in DoResolveOrReject() [2] on another thread before ThenPromise() returns.

[1] http://searchfox.org/mozilla-central/rev/5ee2bd8800b007d6c120d9521d5bf01131885afb/xpcom/threads/MozPromise.h#634

[2] http://searchfox.org/mozilla-central/rev/5ee2bd8800b007d6c120d9521d5bf01131885afb/xpcom/threads/MozPromise.h#409

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1323155 - fix data race in mCompletionPromise.

Review commit: https://reviewboard.mozilla.org/r/98354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98354/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8818213 [details]
Bug 1323155 - fix data race in mCompletionPromise.

https://reviewboard.mozilla.org/r/98354/#review98568

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac3e78fed369
fix data race in mCompletionPromise. r=gerald

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ac3e78fed369