1323244 - The "Comments Subject to Etiquette and Contributor Guidelines" link is the enemy of muscle memory

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[(no longer active)]

I have this habit that right after I type a comment, I press Tab+Enter to submit it.  So far I have read the etiquette page a dozen times today by mistakenly opening it this way.  :(

Can we please adjust the tabindexes so that Tab+Enter after entering a comment works again?  Thank you!

Comment 1

[(no longer active)]

I made a PR for this :) https://github.com/mozilla-bteam/bmo/pull/33

Comment 2

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: Patch to fix tabindex property so that the link is removed from tabbing

Autolander is not happy so taking :ehsan's PR and attaching it.

Comment 3

[(no longer active)]

Which Autolander is that?  Sorry, this is my first patch to the bmo github project, not sure what the correct workflow is...

Comment 4

[(no longer active)]

Thanks for the quick review!  Is it possible for this to be deployed tomorrow?  :-)

Comment 5

[David Lawrence [:dkl]]

To https://github.com/mozilla-bteam/bmo.git
   5bb06c8..1413ff3  master -> master

Merged. This will be in the next production update, most likely beginning of next week.

dkl

Comment 6

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

(In reply to :Ehsan Akhgari from comment #3)
> Which Autolander is that?  Sorry, this is my first patch to the bmo github
> project, not sure what the correct workflow is...

Don't worry! And thank you for the patch. 

You can put the link to the PR in the attachment's text field next time.