The "Comments Subject to Etiquette and Contributor Guidelines" link is the enemy of muscle memory

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
User Interface: Modal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Production

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
I have this habit that right after I type a comment, I press Tab+Enter to submit it.  So far I have read the etiquette page a dozen times today by mistakenly opening it this way.  :(

Can we please adjust the tabindexes so that Tab+Enter after entering a comment works again?  Thank you!
(Assignee)

Updated

a year ago
Blocks: 1318781
(Assignee)

Comment 1

a year ago
I made a PR for this :) https://github.com/mozilla-bteam/bmo/pull/33
Created attachment 8818607 [details] [diff] [review]
Patch to fix tabindex property so that the link is removed from tabbing

Autolander is not happy so taking :ehsan's PR and attaching it.
Attachment #8818607 - Flags: review?(dkl)
Attachment #8818607 - Flags: review?(dkl) → review+
(Assignee)

Comment 3

a year ago
Which Autolander is that?  Sorry, this is my first patch to the bmo github project, not sure what the correct workflow is...
(Assignee)

Comment 4

a year ago
Thanks for the quick review!  Is it possible for this to be deployed tomorrow?  :-)
To https://github.com/mozilla-bteam/bmo.git
   5bb06c8..1413ff3  master -> master

Merged. This will be in the next production update, most likely beginning of next week.

dkl
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(In reply to :Ehsan Akhgari from comment #3)
> Which Autolander is that?  Sorry, this is my first patch to the bmo github
> project, not sure what the correct workflow is...

Don't worry! And thank you for the patch. 

You can put the link to the PR in the attachment's text field next time.

Updated

a year ago
Assignee: nobody → ehsan
You need to log in before you can comment on or make changes to this bug.