Closed
Bug 1323330
Opened 7 years ago
Closed 7 years ago
test_animation_properties.html should run with the Web Animation API pref
Categories
(Core :: DOM: Animation, defect, P3)
Core
DOM: Animation
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(4 files)
13.29 KB,
patch
|
Details | Diff | Splinter Review | |
3.89 KB,
patch
|
Details | Diff | Splinter Review | |
58 bytes,
text/x-review-board-request
|
boris
:
review+
|
Details |
58 bytes,
text/x-review-board-request
|
boris
:
review+
|
Details |
I just tried tests in dom/animation/chrome with disabling the pref of Web Animation Core APIs, it showed me that bunch of test cases for missing keyframes failed. We need to replace IsCoreAPIEnabled (e.g. [1]) with IsCoreAPIEnabledForCaller. Or pass a boolean flag named isMissingKeyframesSupported that represents IsCoreAPIEnabled or on chrome privilege. [1] https://hg.mozilla.org/mozilla-central/file/489f981e8c2b/dom/animation/KeyframeUtils.cpp#l469
Assignee | ||
Comment 1•7 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #0) > Or pass a boolean flag named > isMissingKeyframesSupported that represents IsCoreAPIEnabled or on chrome > privilege. I've done this way, but this breaks test_simulate_compute_values_failure.html. test_simulate_compute_values_failure.html runs with disabling the pref on *chrome* privilege. We need to figure out that both of tests live with the pref off.
Assignee | ||
Comment 2•7 years ago
|
||
We need to fix this until missing keyframe handling moves to beta.
Priority: -- → P3
Assignee | ||
Comment 3•7 years ago
|
||
This patch moves test_simulate_compute_values_failure.html into dom/animation/test/mozilla and is run without chrome privilege and uses SpecialPoweres.wrap(). But it failed, because I could not find any ways to wrap a keyframe object which passed to Element.animate().
Assignee | ||
Comment 4•7 years ago
|
||
I've decided to run test_animation_properties.html with the Web Animation Core API pref and skip test cases in test_restyle.html that need missing keyframe handling.
Summary: Handling missing keyframes feature should check IsCoreAPIEnabledForCaller() instead of IsCoreAPIEnabled() → test_animation_properties.html should run with the Web Animation API pref
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
FYI, here is a try without the Web Animation Core API pref. There are some failures of test_interfaces.html, actually I did miss something related to the pref, but it's not related to this bug. https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b7d9f8420cf2ef93d12832fab596230edd1b7eb
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8818469 [details] Bug 1323330 - Part 1: Run test_animation_properties.html with the Web Animation API pref. https://reviewboard.mozilla.org/r/98522/#review100060
Attachment #8818469 -
Flags: review?(boris.chiou) → review+
Comment 9•7 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #7) > FYI, here is a try without the Web Animation Core API pref. > There are some failures of test_interfaces.html, actually I did miss > something related to the pref, but it's not related to this bug. > > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=5b7d9f8420cf2ef93d12832fab596230edd1b7eb Looks like we need to file a bug for these failures, right?
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8818470 [details] Bug 1323330 - Part 2: Skip test cases involving missing keyframs. https://reviewboard.mozilla.org/r/98524/#review100066
Attachment #8818470 -
Flags: review?(boris.chiou) → review+
Assignee | ||
Comment 11•7 years ago
|
||
(In reply to Boris Chiou [:boris] from comment #9) > (In reply to Hiroyuki Ikezoe (:hiro) from comment #7) > > FYI, here is a try without the Web Animation Core API pref. > > There are some failures of test_interfaces.html, actually I did miss > > something related to the pref, but it's not related to this bug. > > > > https://treeherder.mozilla.org/#/ > > jobs?repo=try&revision=5b7d9f8420cf2ef93d12832fab596230edd1b7eb > > Looks like we need to file a bug for these failures, right? Right. Filed bug 1324655. I hope we will not face any problem when merging current mozilla-central to beta though.
Assignee | ||
Comment 12•7 years ago
|
||
Thank you, Boris! Welcome back!
Comment 13•7 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #12) > Thank you, Boris! Welcome back! :)
Comment 14•7 years ago
|
||
Pushed by hiikezoe@mozilla-japan.org: https://hg.mozilla.org/integration/autoland/rev/1745be99c571 Part 1: Run test_animation_properties.html with the Web Animation API pref. r=boris https://hg.mozilla.org/integration/autoland/rev/04b53b298a52 Part 2: Skip test cases involving missing keyframs. r=boris
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1745be99c571 https://hg.mozilla.org/mozilla-central/rev/04b53b298a52
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•