1323330 - test_animation_properties.html should run with the Web Animation API pref

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

I just tried tests in dom/animation/chrome with disabling the pref of Web Animation Core APIs, it showed me that bunch of test cases for missing keyframes failed.  We need to replace IsCoreAPIEnabled (e.g. [1]) with IsCoreAPIEnabledForCaller.  Or pass a boolean flag named isMissingKeyframesSupported that represents IsCoreAPIEnabled or on chrome privilege.

[1] https://hg.mozilla.org/mozilla-central/file/489f981e8c2b/dom/animation/KeyframeUtils.cpp#l469

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: A patch tried to resolve this

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)
> Or pass a boolean flag named
> isMissingKeyframesSupported that represents IsCoreAPIEnabled or on chrome
> privilege.

I've done this way, but this breaks test_simulate_compute_values_failure.html. test_simulate_compute_values_failure.html runs with disabling the pref on *chrome* privilege.  We need to figure out that both of tests live with the pref off.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

We need to fix this until missing keyframe handling moves to beta.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Run test_simulate_compute_values_failure.html in content and use SpecialPowers.wrap() there

This patch moves test_simulate_compute_values_failure.html into dom/animation/test/mozilla and is run without chrome privilege and uses SpecialPoweres.wrap().  But it failed, because I could not find any ways to wrap a keyframe object which passed to Element.animate().

Comment 4

[Hiroyuki Ikezoe (:hiro)]

I've decided to run test_animation_properties.html with the Web Animation Core API pref and skip test cases in test_restyle.html that need missing keyframe handling.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1323330 - Part 1: Run test_animation_properties.html with the Web Animation API pref.

Handling missing keyframe is behind the pref value regardless whether the
script runs on chrome privilege or not. So the pref has to be set explicitly.

Review commit: https://reviewboard.mozilla.org/r/98522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98522/

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1323330 - Part 2: Skip test cases involving missing keyframs.

Review commit: https://reviewboard.mozilla.org/r/98524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98524/

Comment 7

[Hiroyuki Ikezoe (:hiro)]

FYI, here is a try without the Web Animation Core API pref.
There are some failures of test_interfaces.html, actually I did miss something related to the pref, but it's not related to this bug.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b7d9f8420cf2ef93d12832fab596230edd1b7eb

Comment 8

[Boris Chiou [:boris]]

Comment on attachment 8818469 [details]
Bug 1323330 - Part 1: Run test_animation_properties.html with the Web Animation API pref.

https://reviewboard.mozilla.org/r/98522/#review100060

Comment 9

[Boris Chiou [:boris]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #7)
> FYI, here is a try without the Web Animation Core API pref.
> There are some failures of test_interfaces.html, actually I did miss
> something related to the pref, but it's not related to this bug.
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=5b7d9f8420cf2ef93d12832fab596230edd1b7eb

Looks like we need to file a bug for these failures, right?

Comment 10

[Boris Chiou [:boris]]

Comment on attachment 8818470 [details]
Bug 1323330 - Part 2: Skip test cases involving missing keyframs.

https://reviewboard.mozilla.org/r/98524/#review100066

Comment 11

[Hiroyuki Ikezoe (:hiro)]

(In reply to Boris Chiou [:boris] from comment #9)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #7)
> > FYI, here is a try without the Web Animation Core API pref.
> > There are some failures of test_interfaces.html, actually I did miss
> > something related to the pref, but it's not related to this bug.
> > 
> > https://treeherder.mozilla.org/#/
> > jobs?repo=try&revision=5b7d9f8420cf2ef93d12832fab596230edd1b7eb
> 
> Looks like we need to file a bug for these failures, right?

Right.  Filed bug 1324655.  I hope we will not face any problem when merging current mozilla-central to beta though.

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Thank you, Boris! Welcome back!

Comment 13

[Boris Chiou [:boris]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #12)
> Thank you, Boris! Welcome back!

:)

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1745be99c571
Part 1: Run test_animation_properties.html with the Web Animation API pref. r=boris
https://hg.mozilla.org/integration/autoland/rev/04b53b298a52
Part 2: Skip test cases involving missing keyframs. r=boris

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1745be99c571
https://hg.mozilla.org/mozilla-central/rev/04b53b298a52