Closed
Bug 1323384
Opened 7 years ago
Closed 7 years ago
stylo: add a "stylo" variable to the reftest condition sandbox
Categories
(Testing :: Reftest, defect)
Testing
Reftest
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: heycam, Unassigned)
References
Details
Attachments
(1 file)
For crashtests that are currently crashing, which we want to skip for now in MOZ_STYLO builds, it will be easier to annotate them as skip-if(stylo) rather than having a duplicate crashtest-stylo.list (and a separate crashtest-stylo job) in which we skip them unconditionally.
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Component: CSS Parsing and Computation → Reftest
Product: Core → Testing
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8818472 [details] Bug 1323384 - Add a "stylo" variable to the reftest condition sandbox. https://reviewboard.mozilla.org/r/98534/#review98792 ::: layout/tools/reftest/reftest.jsm:765 (Diff revision 1) > +#ifdef MOZ_STYLO > + sandbox.stylo = true; > +#else > + sandbox.stylo = false; > +#endif > + Maybe move this section to somewhere near other conditional statements (MOZ_WEBRTC, MOZ_ASAN) above.
Attachment #8818472 -
Flags: review?(xidorn+moz) → review+
Comment hidden (mozreview-request) |
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/602c1549de91 Add a "stylo" variable to the reftest condition sandbox. r=xidorn
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/602c1549de91
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•