1323400 - [PointerEvents] Long taps keeps firing the "pointermove"

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Cynthia Tang [:cynthiatang]]

Steps to reproduce:
 1. Launch Firefox with Pointer Events
 2. Open http://rbyers.github.io/eventTest.html 
 3. Long tap in an empty area

Expected result:
 - pointerType="touch"

Actual result:
 - pointerType="touch"
 - But it keeps firing the "pointermove" 
 - Videos:
    - Enable pointerEvents: https://youtu.be/a9ziGiI99E4
    - Disable pointerEvents: https://youtu.be/ms7ClnXw0Co

Environment:
 - Devices: Surface 3
 - OS: Windows 10 Pro. (64bit)
 - Firefox:53.0a1 (2016-11-30) (64-bit)

Comment 1

[Ming-Chou Shih [:stone]]

Without export MOZ_USE_XINPUT2=1, OS keeps firing mousemove and then we generates pointermove from those mousemove events.

As I know, the touch functionality is not working w/o export MOZ_USE_XINPUT2=1. And there are some bugs with MOZ_USE_XINPUT2=1.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

The bug was reported on windows; however comment 1 confusingly indicated a linux configuration. Worth checking it again.

Comment 4

[Edgar Chen [:edgar]]

I could reproduce it on Windows Surface, pointermove event keeps being fired even if the touch isn't moved.

Comment 5

[Edgar Chen [:edgar]]

TouchManager will filter out the duplicated events if the touch isn't changed, https://searchfox.org/mozilla-central/rev/5c8ea961d04767db723a0a15e3a8f7fbca154129/layout/base/TouchManager.cpp#276-280. And the pointer event seems doesn't handle this well.

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1323400 - Part 1: Mark Touch::Equals as a const method;

Comment 7

[Edgar Chen [:edgar]]

Attachment: Bug 1323400 - Part 2: Filter out duplicated touchmove for pointer event;

Comment 8

[Edgar Chen [:edgar]]

Attachment: Bug 1323400 - Part 3-1: Refactor test_multiple_touches.html;

To make it easier to add new test without introudcing duplicated code.

Comment 9

[Edgar Chen [:edgar]]

Attachment: Bug 1323400 - Part 3-2: Add test;

Comment 10

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=127b62a726a3046cabdf0d0e736f7597f1b5ffbc&group_state=expanded

Comment 11

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=c54400e99031993b13ae5a4ae45359b1936e00eb&group_state=expanded

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe21a09ef43f
Part 1: Mark Touch::Equals as a const method; r=smaug
https://hg.mozilla.org/integration/autoland/rev/b526bd580215
Part 2: Filter out duplicated touchmove for pointer event; r=smaug
https://hg.mozilla.org/integration/autoland/rev/8a29492017e3
Part 3-1: Refactor test_multiple_touches.html; r=smaug
https://hg.mozilla.org/integration/autoland/rev/b49310f66efe
Part 3-2: Add test; r=smaug

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fe21a09ef43f
https://hg.mozilla.org/mozilla-central/rev/b526bd580215
https://hg.mozilla.org/mozilla-central/rev/8a29492017e3
https://hg.mozilla.org/mozilla-central/rev/b49310f66efe