1323402 - Crashes at TexImage2D/TexSubImage2D under conformance2/textures

Status: RESOLVED DUPLICATE of bug 1323617

(Core :: Graphics: CanvasWebGL, defect)

Description

[Peter Chang[:pchang]]

There are lots of crashes related to TexImage2D/TexSubImage2D from the following test cases.

conformance2/textures/canvas_sub_rectangle/
conformance2/textures/video/

This is an example for crash test cases.

https://www.khronos.org/registry/webgl/sdk/tests/conformance2/textures/video/tex-2d-rg16f-rg-float.html?webglVersion=2.0

Comment 1

[Peter Chang[:pchang]]

If I skipped pixelStore API in [1], I couldn't reproduce the crash.
And the same workaround could be applied to test cases under canvas_sub_rectangle.

[1]https://github.com/KhronosGroup/WebGL/blob/master/conformance-suites/2.0.0/js/tests/tex-image-and-sub-image-2d-with-video.js#L114

Comment 2

[Peter Chang[:pchang]]

Jeff, it also works if I comment the pixelstore call at [1].

[1]http://searchfox.org/mozilla-central/source/dom/canvas/TexUnpackBlob.cpp#786

Comment 3

[Vincent Liu[:vliu]]

(In reply to Peter Chang[:pchang] from comment #2)
> Jeff, it also works if I comment the pixelstore call at [1].
> 
> [1]http://searchfox.org/mozilla-central/source/dom/canvas/TexUnpackBlob.
> cpp#786

Hi Jeff,
I'd tried to test again all crash issues in conformance2/textures/canvas_sub_rectangle/ and conformance2/textures/video/ with above modification. Except [2], all of them were relative to calling this function. Here is for your information.

[2]: conformance2/textures/video/tex-2d-rg32f-rg-float.html

Comment 4

[Vincent Liu[:vliu]]

(In reply to Vincent Liu[:vliu] from comment #3)
> (In reply to Peter Chang[:pchang] from comment #2)
> > Jeff, it also works if I comment the pixelstore call at [1].
> > 
> > [1]http://searchfox.org/mozilla-central/source/dom/canvas/TexUnpackBlob.
> > cpp#786
> 
> Hi Jeff,
> I'd tried to test again all crash issues in
> conformance2/textures/canvas_sub_rectangle/ and conformance2/textures/video/
> with above modification. Except [2], all of them were relative to calling
> this function. Here is for your information.
> 
> [2]: conformance2/textures/video/tex-2d-rg32f-rg-float.html

Sorry, [2] should be conformance2/textures/video/tex-2d-rgba32f-rgba-float.html

Comment 6

[Vincent Liu[:vliu]]

Here were the try result.

1. With Comment 2 in this bug
   https://treeherder.mozilla.org/#/jobs?repo=try&revision=4de8794b565edb19d56cc967d1faf02f4d4c92e2

2. With fix in bug 1323617
   https://treeherder.mozilla.org/#/jobs?repo=try&revision=8475d5648ccc069177cf0e1c3fcc0be3c51f2b1e