Closed
Bug 1323402
Opened 7 years ago
Closed 7 years ago
Crashes at TexImage2D/TexSubImage2D under conformance2/textures
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1323617
Tracking | Status | |
---|---|---|
firefox53 | --- | affected |
People
(Reporter: pchang, Assigned: jgilbert)
References
Details
There are lots of crashes related to TexImage2D/TexSubImage2D from the following test cases. conformance2/textures/canvas_sub_rectangle/ conformance2/textures/video/ This is an example for crash test cases. https://www.khronos.org/registry/webgl/sdk/tests/conformance2/textures/video/tex-2d-rg16f-rg-float.html?webglVersion=2.0
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Comment 1•7 years ago
|
||
If I skipped pixelStore API in [1], I couldn't reproduce the crash. And the same workaround could be applied to test cases under canvas_sub_rectangle. [1]https://github.com/KhronosGroup/WebGL/blob/master/conformance-suites/2.0.0/js/tests/tex-image-and-sub-image-2d-with-video.js#L114
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jgilbert
Reporter | ||
Comment 2•7 years ago
|
||
Jeff, it also works if I comment the pixelstore call at [1]. [1]http://searchfox.org/mozilla-central/source/dom/canvas/TexUnpackBlob.cpp#786
Comment 3•7 years ago
|
||
(In reply to Peter Chang[:pchang] from comment #2) > Jeff, it also works if I comment the pixelstore call at [1]. > > [1]http://searchfox.org/mozilla-central/source/dom/canvas/TexUnpackBlob. > cpp#786 Hi Jeff, I'd tried to test again all crash issues in conformance2/textures/canvas_sub_rectangle/ and conformance2/textures/video/ with above modification. Except [2], all of them were relative to calling this function. Here is for your information. [2]: conformance2/textures/video/tex-2d-rg32f-rg-float.html
Comment 4•7 years ago
|
||
(In reply to Vincent Liu[:vliu] from comment #3) > (In reply to Peter Chang[:pchang] from comment #2) > > Jeff, it also works if I comment the pixelstore call at [1]. > > > > [1]http://searchfox.org/mozilla-central/source/dom/canvas/TexUnpackBlob. > > cpp#786 > > Hi Jeff, > I'd tried to test again all crash issues in > conformance2/textures/canvas_sub_rectangle/ and conformance2/textures/video/ > with above modification. Except [2], all of them were relative to calling > this function. Here is for your information. > > [2]: conformance2/textures/video/tex-2d-rg32f-rg-float.html Sorry, [2] should be conformance2/textures/video/tex-2d-rgba32f-rgba-float.html
Reporter | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Comment 6•7 years ago
|
||
Here were the try result. 1. With Comment 2 in this bug https://treeherder.mozilla.org/#/jobs?repo=try&revision=4de8794b565edb19d56cc967d1faf02f4d4c92e2 2. With fix in bug 1323617 https://treeherder.mozilla.org/#/jobs?repo=try&revision=8475d5648ccc069177cf0e1c3fcc0be3c51f2b1e
You need to log in
before you can comment on or make changes to this bug.
Description
•