1323600 - Some fields have been converted to properties and won't reset anymore when the binding is recreated

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Marco Bonardo [:mak]]

Bug 1231509 changed some fields to properties, but in some cases that breaks overrides, for example Cliqz reloads the binding after setting the "autocompletepopup" attribute (by removing and reinserting the element in the document) and with a field we get the original getter. Using the defineProperty there's no way to reset the binding to the original state.

Most of the other changes are about modules, that code doesn't seem likely to require support for "resetting" the binding.
The only other change that looks suspicious is "tabbox", maybe we should also revert that, just in case.

For these cases I suggest using a "private" field to memoize the result.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1323600 - Some fields have been converted to properties and won't reset anymore when the binding is recreated.

Review commit: https://reviewboard.mozilla.org/r/98682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98682/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8818732 [details]
Bug 1323600 - Some fields have been converted to properties and won't reset anymore when the binding is recreated.

https://reviewboard.mozilla.org/r/98682/#review98998

*facepalm*

Comment 3

[Marco Bonardo [:mak]]

[Tracking Requested - why for this release]: It's breaking partners add-ons.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21d927623407
Some fields have been converted to properties and won't reset anymore when the binding is recreated. r=mossop

Comment 5

[Julien Cristau [:jcristau]]

tracking 52+ as new regression

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/21d927623407

Comment 7

[Marco Bonardo [:mak]]

Comment on attachment 8818732 [details]
Bug 1323600 - Some fields have been converted to properties and won't reset anymore when the binding is recreated.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1231509
[User impact if declined]: some add-ons, like Cliqz, are broken
[Is this code covered by automated tests?]: the touched code is functionally tested, there's no test for the add-ons breakage fixed here
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: will be tested by Cliqz
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial code change
[String changes made/needed]: none

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8818732 [details]
Bug 1323600 - Some fields have been converted to properties and won't reset anymore when the binding is recreated.

fix regression for add-ons in aurora52

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7a9e103be350