Closed Bug 1323600 Opened 3 years ago Closed 3 years ago

Some fields have been converted to properties and won't reset anymore when the binding is recreated

Categories

(Firefox :: Address Bar, defect, P1)

52 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 + fixed
firefox53 + fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: regression, Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1231509 changed some fields to properties, but in some cases that breaks overrides, for example Cliqz reloads the binding after setting the "autocompletepopup" attribute (by removing and reinserting the element in the document) and with a field we get the original getter. Using the defineProperty there's no way to reset the binding to the original state.

Most of the other changes are about modules, that code doesn't seem likely to require support for "resetting" the binding.
The only other change that looks suspicious is "tabbox", maybe we should also revert that, just in case.

For these cases I suggest using a "private" field to memoize the result.
Priority: -- → P1
Whiteboard: [fxsearch]
Comment on attachment 8818732 [details]
Bug 1323600 - Some fields have been converted to properties and won't reset anymore when the binding is recreated.

https://reviewboard.mozilla.org/r/98682/#review98998

*facepalm*
Attachment #8818732 - Flags: review?(dtownsend) → review+
[Tracking Requested - why for this release]: It's breaking partners add-ons.
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/21d927623407
Some fields have been converted to properties and won't reset anymore when the binding is recreated. r=mossop
tracking 52+ as new regression
https://hg.mozilla.org/mozilla-central/rev/21d927623407
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment on attachment 8818732 [details]
Bug 1323600 - Some fields have been converted to properties and won't reset anymore when the binding is recreated.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1231509
[User impact if declined]: some add-ons, like Cliqz, are broken
[Is this code covered by automated tests?]: the touched code is functionally tested, there's no test for the add-ons breakage fixed here
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: will be tested by Cliqz
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial code change
[String changes made/needed]: none
Attachment #8818732 - Flags: approval-mozilla-aurora?
Comment on attachment 8818732 [details]
Bug 1323600 - Some fields have been converted to properties and won't reset anymore when the binding is recreated.

fix regression for add-ons in aurora52
Attachment #8818732 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Version: unspecified → 52 Branch
You need to log in before you can comment on or make changes to this bug.