1323606 - implement the pref layout.show_previous_page for e10s

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

Turns out this is easy once I remembered where the code was.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 2

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 8818735 [details] [diff] [review]
patch

Review of attachment 8818735 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, nice catch. I'm not a peer for view/ though, so maybe someone else will need to review this.

::: view/nsView.cpp
@@ +38,5 @@
>    mViewManager = aViewManager;
>    mDirtyRegion = nullptr;
>    mWidgetIsTopLevel = false;
> +
> +  static bool addedShowPreviousPage = false;

nit: I think the convention is normally sShowPreviousPageInitialized?

Comment 3

[Timothy Nikkel (:tnikkel)]

(In reply to George Wright (:gw280) (:gwright) from comment #2)
> nit: I think the convention is normally sShowPreviousPageInitialized?

Changed it.

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 8818735 [details] [diff] [review]
patch

>-  return mFrame ? mFrame->PresContext()->PresShell()->IsPaintingSuppressed() : false;
>+  return sShowPreviousPage && mFrame ? mFrame->PresContext()->PresShell()->IsPaintingSuppressed() : false;

While we're here we might as well simplify this expression.
"a ? b : false" is equivalent to "a && b", so the above
can be written as:
return sShowPreviousPage && mFrame &&
       mFrame->PresContext()->PresShell()->IsPaintingSuppressed();

Also, I can't seem to find any documentation for what the pref
"layout.show_previous_page" is supposed to do.  Can you document
the exact semantics either here or in nsSubDocumentFrame.cpp, please?

Comment 5

[Timothy Nikkel (:tnikkel)]

Done.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf9d3767e4e8
Implement the pref layout.show_previous_page for e10s. r=gw280 r=mats

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cf9d3767e4e8