Closed
Bug 1323606
Opened 7 years ago
Closed 7 years ago
implement the pref layout.show_previous_page for e10s
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(1 file)
1.86 KB,
patch
|
gw280
:
review+
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
Turns out this is easy once I remembered where the code was.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8818735 -
Flags: review?(gwright)
Comment 2•7 years ago
|
||
Comment on attachment 8818735 [details] [diff] [review] patch Review of attachment 8818735 [details] [diff] [review]: ----------------------------------------------------------------- lgtm, nice catch. I'm not a peer for view/ though, so maybe someone else will need to review this. ::: view/nsView.cpp @@ +38,5 @@ > mViewManager = aViewManager; > mDirtyRegion = nullptr; > mWidgetIsTopLevel = false; > + > + static bool addedShowPreviousPage = false; nit: I think the convention is normally sShowPreviousPageInitialized?
Attachment #8818735 -
Flags: review?(gwright) → review+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to George Wright (:gw280) (:gwright) from comment #2) > nit: I think the convention is normally sShowPreviousPageInitialized? Changed it.
Assignee | ||
Updated•7 years ago
|
Attachment #8818735 -
Flags: review?(mats)
Comment 4•7 years ago
|
||
Comment on attachment 8818735 [details] [diff] [review] patch >- return mFrame ? mFrame->PresContext()->PresShell()->IsPaintingSuppressed() : false; >+ return sShowPreviousPage && mFrame ? mFrame->PresContext()->PresShell()->IsPaintingSuppressed() : false; While we're here we might as well simplify this expression. "a ? b : false" is equivalent to "a && b", so the above can be written as: return sShowPreviousPage && mFrame && mFrame->PresContext()->PresShell()->IsPaintingSuppressed(); Also, I can't seem to find any documentation for what the pref "layout.show_previous_page" is supposed to do. Can you document the exact semantics either here or in nsSubDocumentFrame.cpp, please?
Attachment #8818735 -
Flags: review?(mats) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Done.
Pushed by tnikkel@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cf9d3767e4e8 Implement the pref layout.show_previous_page for e10s. r=gw280 r=mats
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cf9d3767e4e8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•6 years ago
|
Product: Core → Core Graveyard
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•