1323703 - Implement a method to create DXVA2 decoder for DXVA2Manager

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Alastor Wu [:alwu]]

In order to decode video with DXVA2 decoder directly, DXVA2Manager needs to hold the ref of the decoder.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1323703 - implement a method to create DXVA2 decoder.

Review commit: https://reviewboard.mozilla.org/r/98820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98820/

Comment 2

[Alastor Wu [:alwu]]

Comment on attachment 8818857 [details]
Bug 1323703 - implement a method to create DXVA2 decoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98820/diff/1-2/

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 8818857 [details]
Bug 1323703 - implement a method to create DXVA2 decoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98820/diff/2-3/

Comment 4

[Alastor Wu [:alwu]]

Still trying to figure out why Win7 test cases on try server would fail...

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8818857 [details]
Bug 1323703 - implement a method to create DXVA2 decoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98820/diff/3-4/

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8818857 [details]
Bug 1323703 - implement a method to create DXVA2 decoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98820/diff/4-5/

Comment 7

[Matt Woodrow (:mattwoodrow)]

I probably won't be able to get to this until early Jan sorry, feel free to ask another reviewer if you'd like it done earlier :)

Comment 8

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8818857 [details]
Bug 1323703 - implement a method to create DXVA2 decoder.

https://reviewboard.mozilla.org/r/98820/#review103708

::: dom/media/platforms/wmf/DXVA2Manager.cpp:1026
(Diff revision 5)
>    MOZ_ASSERT(NS_IsMainThread());
>    --sDXVAVideosCount;
>  }
>  
> +bool
> +DXVA2Manager::IsInvalidResolution(const uint32_t& aWidth,

Maybe 'IsUnsupportedResolution'?

These resolutions aren't really invalid as such, we just don't want to use them since they are often slow.

Comment 9

[Alastor Wu [:alwu]]

Comment on attachment 8818857 [details]
Bug 1323703 - implement a method to create DXVA2 decoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98820/diff/5-6/

Comment 10

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de1bd254cd175245f6a0f2f90b1dd6a8e17cb693

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a11af0e0fcf
implement a method to create DXVA2 decoder. r=mattwoodrow

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5a11af0e0fcf