1323767 - Fix the indentation and inconsistent brace-style, and switch to using ES6 method definitions in videocontrols.xml

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

As the summary says... the indentation in videocontrols.xml uses 4-space whereas in most files of mozilla-central we use 2-space.

Internal to the file we inconsistently use braces around single line if-blocks. The inconsistency makes it harder to scan, and allows for easy bugs to get introduced.

We can also now switch to using the shorter ES6 method definitions as described at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1323767 - Fix the indentation and inconsistent brace-style, and switch to using ES6 method definitions in videocontrols.xml.

Review commit: https://reviewboard.mozilla.org/r/98858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98858/

Comment 2

[Ray Lin[:ralin]]

Comment on attachment 8818945 [details]
Bug 1323767 - Fix the indentation and inconsistent brace-style, and switch to using ES6 method definitions in videocontrols.xml.

https://reviewboard.mozilla.org/r/98858/#review99274

Look good to me, it's great to have this patch! A much better videocontrols.xml than before. Thanks you!!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e8397caf8c5
Fix the indentation and inconsistent brace-style, and switch to using ES6 method definitions in videocontrols.xml. r=ralin

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e8397caf8c5