bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Fix the indentation and inconsistent brace-style, and switch to using ES6 method definitions in videocontrols.xml

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
Video/Audio Controls
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

As the summary says... the indentation in videocontrols.xml uses 4-space whereas in most files of mozilla-central we use 2-space.

Internal to the file we inconsistently use braces around single line if-blocks. The inconsistency makes it harder to scan, and allows for easy bugs to get introduced.

We can also now switch to using the shorter ES6 method definitions as described at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8818945 [details]
Bug 1323767 - Fix the indentation and inconsistent brace-style, and switch to using ES6 method definitions in videocontrols.xml.

https://reviewboard.mozilla.org/r/98858/#review99274

Look good to me, it's great to have this patch! A much better videocontrols.xml than before. Thanks you!!
Attachment #8818945 - Flags: review?(ralin) → review+

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5e8397caf8c5
Fix the indentation and inconsistent brace-style, and switch to using ES6 method definitions in videocontrols.xml. r=ralin
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5e8397caf8c5
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.