132381 - Text zoom doesn't work when font properties fully specified (e.g., 'font' shorthand property)

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Sascha Claus]

Mozilla 0.9.9 {Build ID: 2002031104} on Windows98, seems to be platform independent

If CSS' line-height is specified via the 'font' shorthand property,
font: 110%/120% Arial; (font-size/line-height font-family)
the text zoom doesn't work for that element.

For other elements it works and font sizes set via prefs work.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This happens because setting "font" sets "font-size-adjust".  For some reason,
any value other than "inherit" for font-size-adjust disables text zoom on an
element.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Um, ignore that.  Just setting font-size-adjust is no good.  This actually
happens any time all the font properties are fully specified (and yes, my build
has the patch for bug 131454 in it).

Comment 3

[Sascha Claus]

bzbarsky: Why don't you let some terms in the summary a usual user would search for?

Comment 4

[Uwe Schröder]

Test Case: http://www.ohrbelag.de/mozilla-bug-02.html

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

My fix for bug 131454 wasn't quite enough.  I need to do the same thing for
percent.

Comment 6

[Chris Waterson]

Comment on attachment 78303 [details] [diff] [review]
patch

r= or sr=waterson, whichever helps.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

*** Bug 136389 has been marked as a duplicate of this bug. ***

Comment 8

[David Hyatt]

Comment on attachment 78303 [details] [diff] [review]
patch

r=hyatt

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Checked in to trunk, 2002-04-10 20:29 PDT.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 78303 [details] [diff] [review]
patch

a=[e-mail] for 1.0 branch

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to MOZILLA_1_0_0_BRANCH 2002-04-13 08:40 PDT.

Comment 12

[Sascha Claus]

Was the fix also checked into the trunk or will someone make a different patch
for the trunk or ...?

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

See comment 9.

Comment 14

[Sascha Claus]

Oops...

Fixed with {Build ID: 2002041217} on Win98

Comment 15

[Hixie (not reading bugmail)]

VERIFIED FIXED on trunk using http://www.ohrbelag.de/mozilla-bug-02.html

Comment 16

[Asa Dotzler [:asa]]

adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.

Comment 17

[Madhur Bhatia]

using http://www.ohrbelag.de/mozilla-bug-02.html testcase,
verifeid fixed in buildID: 2002-05-22-1.0.0 branch on win2000

changing keyword fixed1.0.0 to verified1.0.0