58 bytes, text/x-review-board-request
Bug 1321783 added nsIHttpChannelInternal.beConservative as a way to make a channel use conservative TLS settings when connecting. It took a while, but I managed to get together a test for this feature, so I'm adding it now.
Comment on attachment 8819062 [details] bug 1323843 - add a test for conservative TLS option added in bug 1321783 https://reviewboard.mozilla.org/r/98926/#review99228 really appreciate this. thanks.
Attachment #8819062 - Flags: review?(mcmanus) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/5182a866ae5a add a test for conservative TLS option added in bug 1321783 r=mcmanus
Comment on attachment 8819062 [details] bug 1323843 - add a test for conservative TLS option added in bug 1321783 Approval Request Comment [Feature/Bug causing the regression]: n/a (this is just a test for the feature added in bug 1321783) [User impact if declined]: no test coverage for feature [Is this code covered by automated tests?]: it is the test [Has the fix been verified in Nightly?]: not by QA, no (although, again, this is the test) [Needs manual test from QE? If yes, steps to reproduce]: probably not [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: it's just a test [String changes made/needed]: none
3 years ago
This can go in with a=test-only.
Whiteboard: [necko-active] → [necko-active][checkin-needed-aurora]
Oh, right - of course. Thanks! In the meantime, bug 1321783 got uplifted to beta, so we need this there as well.
Disabled on Beta for permafailing. Looks like the test depends on bug 1286694. https://hg.mozilla.org/releases/mozilla-beta/rev/5df4fe2cddb45311fa3e8ac0dc58f04364ffffb9 https://treeherder.mozilla.org/logviewer.html#?job_id=67034087&repo=mozilla-beta
Thanks for tracking that down. It looks like I'm a bit late to uplift that and re-enable this test, since the tree is now closed for uplift week (I would have done it yesterday with a=test-only, but claiming that the relevant patch from bug 1286694 is test-only is a slight stretch).
Code freeze for 51 isn't until next week.
Oh - I must be misunderstanding the tree status annotation. In any case, I went ahead and asked for uplift for the part 2 patch in bug 1286694 (since part 1 landed in 50). After that lands, we should be able to just back out 5df4fe2cddb45311fa3e8ac0dc58f04364ffffb9.
You need to log in before you can comment on or make changes to this bug.