1324014 - Whitelist Linux pings with missing screen resolution in the Hardware Report

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Metrics: Pipeline, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

It looks like the Firefox Hardware Survey [1] under counts the data for the Linux users.

We should dig into that and figure out why this is happening.

[1] - https://metrics.mozilla.com/firefox-hardware-survey/

Comment 1

[Alessio Placitelli [:Dexter]]

This is interesting. It turns out Linux pings are coming with no screen resolution information and we're filtering them because of this.

Screen resolution should come from [1], but it doesn't implement |FindMonitors|. It seems that support for the screen resolution landed in bug 1175005, then it was backed out, then it landed again but without the Linux support. Apparently, it was backed out due to a a11y linux-only performance regression (see bug 1176856) and never fixed again.

[1] - https://dxr.mozilla.org/mozilla-central/source/widget/GfxInfoX11.cpp

Comment 2

[Georg Fritzsche [:gfritzsche]]

As this is expected, it should probably just include them and bucketed them into "other screen res" or so.

It might be helpful here to track the ratio of discarded records, broken down by OS.

Comment 3

[Alessio Placitelli [:Dexter]]

Andre, Rebecca, what should we be doing here?

Comment 4

[Andre Vrignaud [:andre] [Seattle - PST]]

Ali, think we discussed in our meeting - do you still need anything here? Thanks!

Comment 5

[Andre Vrignaud [:andre] [Seattle - PST]]

Grr - Alessio I mean! Sorry about that!

Comment 6

[Alessio Placitelli [:Dexter]]

Nope, I have all I need, thanks. We'll go ahead and whitelist the linux pings with missing screen resolution.

Comment 7

[Alessio Placitelli [:Dexter]]

Attachment: Whitelist broken screen resolutions

That's the PR that fixes Linux data. I'm waiting for a test job to finish before flagging :harter for review.

Comment 8

[Alessio Placitelli [:Dexter]]

Attachment: hwsurvey-weekly-20170801-20171401.json

Sample output

Comment 9

[Alessio Placitelli [:Dexter]]

Comment on attachment 8828901 [details] [review]
Whitelist broken screen resolutions

I'm still unsure how to flag properly for reviewing a PR :-) So flagging both on Github and Bugzilla ;-)

Comment 10

[Alessio Placitelli [:Dexter]]

Attachment: hwsurvey-weekly-20172201-20172801.json

Comment 11

[Alessio Placitelli [:Dexter]]

Comment on attachment 8828901 [details] [review]
Whitelist broken screen resolutions

Ryan, I ran the notebook again. I've attached the updated file for the past week.

The numbers seem to match with the query you mentioned in the PR [1] (not perfectly, due to the other validity checks we have on the HW report). Here's what I mean:

 - Linux: reported ratio ~0,02 / query ratio ~0,02
 - MacOS: reported ratio ~0,062 / query ratio 0,063
 - The rest is Windows

[1] - https://sql.telemetry.mozilla.org/queries/2488/source

Comment 12

[Alessio Placitelli [:Dexter]]

The PR for this bug was merged.