Fingerprinting resistance in pluginarray/mimetypesarray misses own prop names

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52- affected, firefox53 fixed)

Details

(Whiteboard: [tor][fingerprinting])

Attachments

(1 attachment)

The checks added in bug 418986 didn't affect GetSupportedNames.
Blocks: 418986
Depends on: 1324035
Created attachment 8819367 [details] [diff] [review]
Add fingerprinting resistance in GetSupportedNames in nsMimeTypeArray and nsPluginArray
Attachment #8819367 - Flags: review?(kyle)
Attachment #8819367 - Flags: review?(kyle) → review+

Comment 2

6 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcc7b0c683ce
Add fingerprinting resistance in GetSupportedNames in nsMimeTypeArray and nsPluginArray.  r=qdot

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dcc7b0c683ce
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
[Tracking Requested - why for this release]:
Tor Browser will rely on 52ESR, and we would like to request including this patch (off by default in Firefox but on by default in Tor Browser).
Status: RESOLVED → REOPENED
status-firefox52: --- → affected
tracking-firefox52: --- → ?
Resolution: FIXED → ---
Whiteboard: [tor][fingerprinting]
Please don't reopen bugs to request backports.  That's what the approval request flags on patches are for.
Status: REOPENED → RESOLVED
Last Resolved: 6 months ago5 months ago
Resolution: --- → FIXED
In terms of being able to backport this, bug 1316619 _was_ done in time for 52, so that part is there.  But the patches for bug 1324035 aren't on 52, so "nsContentUtils::ResistFingerprinting(mozilla::dom::CallerType aCallerType)" doesn't exist, just the no-args version.  That will require a tiny bit of work to backport.
I don't think I need to be tracking this.  Still happy to take an uplift for it up to early beta.
tracking-firefox52: ? → -
Oh, but more to the point the general design of this patch involves backporting more of bug 1324035 in general....
And that involves backporting some of bug 1316616 or restructuring how the patches in bug 1324035 work a bit.

I won't have time to do this before the uplift, for sure.  I may have time to review someone else's attempts to do this....
If nothing happens soon here, it is going to be => wontfix.
You need to log in before you can comment on or make changes to this bug.