1324053 - Ensure that setting privacy.trackingprotection.annotate_channels to true doesn't regress performance by disabling speculative connect and DNS prefetching

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[(no longer active)]

Bug 1141814 made us disable speculative connect and DNS prefetching when the privacy.trackingprotection.annotate_channels pref is set by setting mLocalBlocklist to true here: <https://hg.mozilla.org/mozilla-central/rev/fb18b507a912#l4.22>

This is bad because according to bug 1122691, doing this can regress page load performance by about 3%.  We only need to do this if we're actually going to block such loads, since we'd be saving time by not running the tracking junk at all.  But we shouldn't be doing this merely to annotate channels.

Comment 1

[(no longer active)]

Attachment: Ensure that speculative connect and DNS prefetching aren't disabled when annotating tracking channels

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8819360 [details] [diff] [review]
Ensure that speculative connect and DNS prefetching aren't disabled when annotating tracking channels

Review of attachment 8819360 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/688f10a74c64
Ensure that speculative connect and DNS prefetching aren't disabled when annotating tracking channels; r=mayhemer

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/688f10a74c64