Ensure that setting privacy.trackingprotection.annotate_channels to true doesn't regress performance by disabling speculative connect and DNS prefetching

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

Bug 1141814 made us disable speculative connect and DNS prefetching when the privacy.trackingprotection.annotate_channels pref is set by setting mLocalBlocklist to true here: <https://hg.mozilla.org/mozilla-central/rev/fb18b507a912#l4.22>

This is bad because according to bug 1122691, doing this can regress page load performance by about 3%.  We only need to do this if we're actually going to block such loads, since we'd be saving time by not running the tracking junk at all.  But we shouldn't be doing this merely to annotate channels.
Blocks: 1170190
Whiteboard: [necko-would-take]
Whiteboard: [necko-would-take] → [necko-active]
Comment on attachment 8819360 [details] [diff] [review]
Ensure that speculative connect and DNS prefetching aren't disabled when annotating tracking channels

Review of attachment 8819360 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8819360 - Flags: review?(honzab.moz) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/688f10a74c64
Ensure that speculative connect and DNS prefetching aren't disabled when annotating tracking channels; r=mayhemer
https://hg.mozilla.org/mozilla-central/rev/688f10a74c64
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.