1324115 - Add a way to get C++ origin attributes from nsIPrincipal

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

For some unclear to me reason we need to always cast nsIPrincipal to BasePrincipal to get OA in C++ friendly way. Why can't we just have [noscript, notxpcom] getter in nsIPrincipal?

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: add a C++ helper in nsIPrincipal.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: replace the callers to use C++ helper.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8820105 [details] [diff] [review]
Part 1: add a C++ helper in nsIPrincipal.

I guess binaryOriginAttributesRef could be called also OriginAttributesRef, but doesn't matter since the binary name is anyhow the right one.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8820106 [details] [diff] [review]
Part 2: replace the callers to use C++ helper.

Thanks.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: add a C++ helper in nsIPrincipal. v2

s/binaryOriginAttributesRef/OriginAttributesRef/

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: add a C++ helper in nsIPrincipal. v3

added 'override' OriginAttributesRef() in BasePrincipal.h, otherwise we will have static analysis failure.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b44e3a356480
Part 1: add a C++ helper in nsIPrincipal. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/26fedcf94afe
Part 2: replace the callers to use C++ helper. r=smaug

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b44e3a356480
https://hg.mozilla.org/mozilla-central/rev/26fedcf94afe