1324119 - DownloadTaskbarProgress.jsm is missing due to being removed from mozilla-central in Bug 1319762

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Philip Chee]

navigator.js tries to import DownloadTaskbarProgress.jsm which now fails since it has been removed from mozilla-central in Bug 1319762
Components.utils.import("resource://gre/modules/DownloadTaskbarProgress.jsm");
This creates a cascade of errors which results in a non-functioning browser.

Comment 1

[Philip Chee]

Attachment: Copy DownloadTaskbarProgress.jsm to /suite/

Just add it to comm-central. No history because I don't think it's worth it.

Comment 2

[Philip Chee]

Attachment: (Patch that actually applies) Copy DownloadTaskbarProgress.jsm to /suite/

Patch that applies without errors.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8819531 [details] [diff] [review]
(Patch that actually applies) Copy DownloadTaskbarProgress.jsm to /suite/

Works. Go for it without history. If I ever find the time I am planning to either remove or rewrite DownloadTaskbarProgress.jsm in Bug 888915. The current one causes problems with the js download manager.

Comment 4

[Ian Neal]

Comment on attachment 8819531 [details] [diff] [review]
(Patch that actually applies) Copy DownloadTaskbarProgress.jsm to /suite/

r/a=me for short term fix

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/e51168b1943756733ed84bacd2e8e8bd9c630ad0

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1324119 - Remove the sole use of MOZALLOC_HAVE_XMALLOC.

When this was added, the xpcom glue was still a thing, and there was a
distinction between things that would build with mozalloc available and
others. There is no such distinction anymore. Anything that has access
to xpcom has access to infallible allocator functions.

Review commit: https://reviewboard.mozilla.org/r/205380/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205380/

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8934442 [details]
Bug 1324119 - Remove the sole use of MOZALLOC_HAVE_XMALLOC.

Sorry, wrong bug number.