Cert error page: Error code link in 'Technical details' shown as html code

RESOLVED FIXED in seamonkey2.50

Status

SeaMonkey
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

SeaMonkey 2.50 Branch
seamonkey2.50
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.46 wontfix, seamonkey2.47 affected, seamonkey2.48 affected, seamonkey2.49esr affected, seamonkey2.50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
STR:
1. Go to https://subdomain.preloaded-hsts.badssl.com/
2. Expand Technical Details

Expected:

subdomain.preloaded-hsts.badssl.com uses an invalid security certificate.

The certificate is only valid for the following names:
*.badssl.com, badssl.com

Error code: SSL_ERROR_BAD_CERT_DOMAIN

Actual:

subdomain.preloaded-hsts.badssl.com uses an invalid security certificate.

The certificate is only valid for the following names:
*.badssl.com, badssl.com 

Error code: <a id="errorCode"
title="SSL_ERROR_BAD_CERT_DOMAIN">SSL_ERROR_BAD_CERT_DOMAIN</a>

---------------------------------------------------------------
Notes:
Similar Android bug:
Bug 1238382 - cert error page: Error code link in 'Technical details' shown as html code.
Bug 1238382 Bring Android's about:certerror and about:neterror closer to the desktop versions.
https://hg.mozilla.org/mozilla-central/rev/1292ce950e07

Bug 431826 - Redesign certificate error page for Firefox as about:certerror.

addDomainErrorLink added in:
Bug 402210 - Should SSL Error page for domain mismatch hyperlink to correct site?

addDomainErrorLink() became addDomainErrorLinks() in:
Bug 1207146 - Add a link to expert technical information in the cert error page.
https://hg.mozilla.org/releases/mozilla-esr45/rev/de962dcbc06c
Which is also where the error code was introduced.
(Assignee)

Comment 1

2 years ago
Created attachment 8819542 [details] [diff] [review]
Patch v1.0 Proposed fix

This patch DOES NOT implement the click event handler for the Error Code. I'm going to spin that into a new bug. This bug only fixes ONE ISSUE as per summary.
Attachment #8819542 - Flags: review?(iann_bugzilla)

Comment 2

2 years ago
Comment on attachment 8819542 [details] [diff] [review]
Patch v1.0 Proposed fix

>+  if (!firstResult) {
>+      sd.textContent = desc;
>+      return;

Do we need to set sd.textContent here as Firefox don't seem to?

r/a=me with that addressed/answered.
Attachment #8819542 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 3

2 years ago
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/8bc108f04b93ea2a9d8fc2552f60b5205b6c2293
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-seamonkey2.46: --- → wontfix
status-seamonkey2.47: --- → affected
status-seamonkey2.48: --- → affected
status-seamonkey2.49esr: --- → affected
status-seamonkey2.50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.50
You need to log in before you can comment on or make changes to this bug.