Closed
Bug 1324208
Opened 7 years ago
Closed 7 years ago
Remove strict arguments poison pill for "caller" property
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file, 1 obsolete file)
7.17 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
https://github.com/tc39/ecma262/pull/689 This let us get rid of the caller checks in UnmappedArgumentsObject::obj_resolve and UnmappedArgumentsObject::obj_enumerate.
Assignee | ||
Comment 1•7 years ago
|
||
JSC and V8 [1,2] already removed the poison pill for strict arguments "caller". [1] https://bugs.webkit.org/show_bug.cgi?id=164859 [2] https://bugs.chromium.org/p/v8/issues/detail?id=5535
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8821554 -
Flags: review?(evilpies)
Comment 2•7 years ago
|
||
Comment on attachment 8821554 [details] [diff] [review] bug1324208.patch Review of attachment 8821554 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! ::: js/src/tests/ecma_5/Function/arguments-caller-callee.js @@ +31,5 @@ > } > } > > function bar() { "use strict"; return arguments; } > +bar().caller; // No error when accessing arguments.caller in ES2017+ I think this becomes more obvious after changing this to assertEq(bar().caller, undefined)
Attachment #8821554 -
Flags: review?(evilpies) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Updated per review comments, carrying r+ from evilpie.
Attachment #8821554 -
Attachment is obsolete: true
Attachment #8822177 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc3918041bb59a435f3a5231ecec622eae5f8746
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/132fd6c77441 Remove strict arguments poison pill for "caller" property per ES2017. r=evilpie
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/132fd6c77441
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•