1324208 - Remove strict arguments poison pill for "caller" property

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[André Bargull [:anba]]

https://github.com/tc39/ecma262/pull/689

This let us get rid of the caller checks in UnmappedArgumentsObject::obj_resolve and UnmappedArgumentsObject::obj_enumerate.

Comment 1

[André Bargull [:anba]]

Attachment: bug1324208.patch

JSC and V8 [1,2] already removed the poison pill for strict arguments "caller".

[1] https://bugs.webkit.org/show_bug.cgi?id=164859
[2] https://bugs.chromium.org/p/v8/issues/detail?id=5535

Comment 2

[Tom S. (please needinfo tschuster)]

Comment on attachment 8821554 [details] [diff] [review]
bug1324208.patch

Review of attachment 8821554 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: js/src/tests/ecma_5/Function/arguments-caller-callee.js
@@ +31,5 @@
>    }
>  }
>  
>  function bar() { "use strict"; return arguments; }
> +bar().caller; // No error when accessing arguments.caller in ES2017+

I think this becomes more obvious after changing this to assertEq(bar().caller, undefined)

Comment 3

[André Bargull [:anba]]

Attachment: bug1324208.patch

Updated per review comments, carrying r+ from evilpie.

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc3918041bb59a435f3a5231ecec622eae5f8746

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/132fd6c77441
Remove strict arguments poison pill for "caller" property per ES2017. r=evilpie

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/132fd6c77441