1324217 - IRC URL links are broken in newer versions of Firefox with ChatZilla tip

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[:Gijs (he/him)]

+++ This bug was initially created as a clone of Bug #1317340 +++
(In reply to Frank-Rainer Grahl from comment #13)
> For what's it worth. This now fails in SeaMonkey 2.50 in a new profile. I
> didn't try a fresh Firefox yet. Was fine before in ESR 45 and up. 
> 
> > Error: TypeError: ChatZillaProtocols is undefined
> > Source File: chrome://chatzilla/content/lib/js/chatzilla-protocol-script.js Line: 10

(In reply to :Gijs Kruitbosch from comment #18)
> Never mind, I misread comment #16. I can reproduce. There's a scoping
> problem. Making ChatZillaProtocols in the jsm use 'var' rather than 'const'
> fixes it. Looking at when this changed...

Comment 1

[:Gijs (he/him)]

See e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1202902#c57

I... don't really understand why this would ever have worked when I tested locally with the patch from bug 1317340. :-\

Comment 2

[:Gijs (he/him)]

Attachment: assign onto the global to avoid scoping problems with let/const,

Comment 3

[Frank-Rainer Grahl (:frg)]

Great. I tried the patch locally and it fixes the problem. 

SeaMonkey en-US Windows x64 build

> User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0 
> SeaMonkey/2.50a1
> Build identifier: 20161217192241

Comment 4

[James Ross]

Comment on attachment 8819556 [details] [diff] [review]
assign onto the global to avoid scoping problems with let/const,

Review of attachment 8819556 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/lib/protocol-handlers.jsm
@@ +21,5 @@
>  const IRCPROT_HANDLER_CONTRACTID =
>      "@mozilla.org/network/protocol;1?name=irc";
>  const IRCSPROT_HANDLER_CONTRACTID =
>      "@mozilla.org/network/protocol;1?name=ircs";
> +this.IRCPROT_HANDLER_CID =

This makes me sad. :(

Comment 5

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/chatzilla/rev/6f73514d10cbf2bdcfac4948a4da4d7f38e9767f