Closed Bug 1324230 Opened 7 years ago Closed 7 years ago

Don't re-parse when deserializing Rust URLs

Categories

(Core :: Networking, defect, P3)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: manishearth, Unassigned)

References

Details

(Whiteboard: [necko-backlog]) 

Currently with the rust-url serialization code we serialize the nsStandardURL and when deserializing reconstruct it from the spec.

We should probably independently serialize/deserialize the rust url.

I guess this applies to Write/Read as well as Serialize/Deserialize? Serialize/Deserialize use URIParams, and I'm not sure if we can easily add the rust components to that. I'm also not sure if fixing this is necessary for perf. They're not xpcom methods so perhaps we don't need them for nsIURI.

rust-url currently has serde/rust-serialize methods implemented on it that just re-parse. As part of this we'll need to update those. I'll work on that. I'd like to avoid a dependency on serde-derive since that brings in aster/syntex, which are nice libraries, but large. I'd rather wait for custom derive to get stable (1.15 is the plan) to use this.
Whiteboard: [necko-backlog]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P1 → P3
We removed RustURL from Gecko in favor of MozURL.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.