1324290 - Thunderbird: x86_64 Daily and installer on Windows unsigned

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Richard Marti (:Paenglab)]

The x86_64 installer and Daily on Windows aren't signed which needs to override the warning to install.

Comment 1

[Richard Marti (:Paenglab)]

Rail, I saw you worked on some signing bugs. Do you know what is needed to sign the  x86_64 Daily and installer?

Comment 2

[Rail Aliiev [:rail]]

1) win64 default is missing 'nightly_signing_servers' and 'dep_signing_servers', like in https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/thunderbird_config.py#l139. It'd be better to add them.

2) win64 also needs something like https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/thunderbird_config.py#l757 for branches we build Daily on.

I think if we address the issues above, it should be signed properly.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: addWin64Signing.patch

Thank you for the info.

This should do the trick.

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8819675 [details] [diff] [review]
addWin64Signing.patch

Review of attachment 8819675 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it! :)

Comment 5

[Richard Marti (:Paenglab)]

Thank you!

I don't know the process to land on buildbot-config. Can I land it directly or is there a other repository to land?

Or could you land it at the right place, please?

Comment 6

[Rail Aliiev [:rail]]

I'll land this tomorrow.

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8819675 [details] [diff] [review]
addWin64Signing.patch

https://hg.mozilla.org/build/buildbot-configs/rev/3ba60d3917ff81d8bce0b073d2f6b55181935193

Comment 8

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/3ba60d3917ff

Comment 9

[Richard Marti (:Paenglab)]

Rail, thank you for the check-in.

Comment 10

[Rail Aliiev [:rail]]

Thank you for the patch! Can you verify tomorrow builds and report back please.

Comment 11

[Richard Marti (:Paenglab)]

I'll do this tomorrow.

Comment 12

[Richard Marti (:Paenglab)]

Unfortunately all Nightlies are busted. I'll check when one is available.

Comment 13

[Richard Marti (:Paenglab)]

There was builds on the FTP server and failed somewhere afterwards.

Checked the installer and the EXE in zip. Both are signed.