1324311 - Crash in mozilla::dom::AudioChannelService::AudioChannelWindow::RequestAudioFocus

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-3d438986-0d95-45e3-9822-83a062161217.
=============================================================

This Fennec-only crash has been around for some time, and has quite a high crash volume, but appears to have no bug filed. Stats for the past 7 days:

> Product       Version Count Percentage Installations
> FennecAndroid 50.0.2  157   38.1%      157
> FennecAndroid 50.1.0  144   35.0%       93
> FennecAndroid 49.0.2   27    6.6%       23
> FennecAndroid 50.0     25    6.1%       16
> FennecAndroid 51.0b7   19    4.6%        8
> FennecAndroid 49.0     14    3.4%       12
> FennecAndroid 51.0b5    8    1.9%        6
> FennecAndroid 53.0a1    8    1.9%        3
> FennecAndroid 50.0.1    3    0.7%        3
> FennecAndroid 50.0b12   3    0.7%        1
> FennecAndroid 49.0b8    2    0.5%        1
> FennecAndroid 49.0b11   1    0.2%        1
> FennecAndroid 52.0a2    1    0.2%        1

The crash address is always 0x56. Perhaps aAgent is null?

Comment 1

[Nicholas Nethercote [inactive]]

alwu, any ideas?

Comment 2

[Nicholas Nethercote [inactive]]

This is the #10 top browser crash in Fennec Nightly for the past 7 days.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1324311 - window-less agent can't own audio focus.

Review commit: https://reviewboard.mozilla.org/r/99398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99398/

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8819759 [details]
Bug 1324311 - window-less agent can't own audio focus.

https://reviewboard.mozilla.org/r/99398/#review99966

Comment 6

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb7309e234dd127f5035816d63c07c333442ba73&selectedJob=33004136

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/699a5d5828dc
window-less agent can't own audio focus. r=baku

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/699a5d5828dc

Comment 9

[Blake Wu [:bwu][:blakewu]]

Alastor, 
Maybe we should uplift it to 52 and even 51. What do you think?

Comment 10

[Sylvestre Ledru [:Sylvestre]]

I was going to ask the same, thanks :)

Comment 11

[Alastor Wu [:alwu]]

Let's wait for a while to see whether the crash has been fixed and make sure there isn't other side effects.

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 8819759 [details]
Bug 1324311 - window-less agent can't own audio focus.

Approval Request Comment
[Feature/Bug causing the regression]: Fix the crash
[User impact if declined]: Still got crash
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No 
[Why is the change risky/not risky?]: Just added another if-condition for return  
[String changes made/needed]: No

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8819759 [details]
Bug 1324311 - window-less agent can't own audio focus.

Fix a crash. Beta51+ & Aurora52+. Should be in 51 beta 10.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7b1a631ae717

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e736096955d7