1324372 - Fixed bottom bar will bounce and flash when page is scrolled

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P3)

Description

[Rachelle Yang [:ryang][[e-mail]]]

Attachment: 螢幕快照 2016-12-19 16.28.20.png

STR:

When users scroll the screen while playing media, the media control bar on the bottom will bounce and flash.

(Test for soundcloud.com)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Note that this is not a bar we display but something the website does. How does the bar behave in Chrome on this device? Does it bounce / flash too?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Low priority ni: Kats has a lot of knowledge about the various behaviors of floating bottom and top bars from websites and how they interact with the sliding address bar. There are compromises that are made to allow Firefox for Android to have a disappearing address bar and be performant & generally correct in the displaying of content.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This appears to be a regression, actually. The bar is position:fixed to the bottom, and at least while the dynamic toolbar is in the process of sliding on or off the screen (before the user lifts their finger) it should not be jumping around. The same happens on my test page at https://people-mozilla.org/~kgupta/bug/1180295.html with the "bottom right" square, and it didn't use to happen.

Note that a frame or two of flicker after the resize is complete is not unexpected, and is hard to avoid, because we resize the content area. But flicker/lag while the toolbar is partially off the screen is not expected.

Comment 4

[Sorina Florean [:sflorean]]

Performed regression-window:
Last good build: 2015-08-19
First bad build: 2015-08-20

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f384789a29dcfd514d25d4a16a97ec5309612d78&tochange=29b2df16e961fbe9a379362ecba6f888d1754bc3

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Huh, that's a surprise to me. But I verified the regression range, and yeah, this seems to have been introduced in the rewrite in bug 1180295.

Comment 6

[Rachelle Yang [:ryang][[e-mail]]]

Hi Blake,

Could you help us with the bug to assign someone from your team for further investigation? 
We are wondering if this is related to platform .

Could you please help with this ? Thank you !

Comment 7

[Blake Wu [:bwu][:blakewu]]

Hi Rachelle,

I cannot see this problem with the latest nightly on my Pixel. Can you let us know which phone and Android version you were using it to see this problem? 
Btw, it is weird that I even cannot see our media control..

Comment 8

[Rachelle Yang [:ryang][[e-mail]]]

Hi Sorina, 
I tested the scenario with the latest Nightly. looks like it worked fine.

Can you kindly let us know know which phone and Android version you were using to identify the regression range? Thank you!

Comment 9

[Sorina Florean [:sflorean]]

Hi all,
Device - regression range: Huawei Honor 5x (Android 5.1.1) and indeed, the media control notification is not displayed.

Comment 10

[Rachelle Yang [:ryang][[e-mail]]]

Hi Blake, 
the issue is 100% reproducible on the latest nightly (today).
But it might be related to layout.


Hi Sorina, the scenario is tested using https://m.soundcloud.com/  on Fennec.
After playing any music, and then pressing back key, the control bar on the bottom designed by soundcloud will bounce and flash.

Comment 11

[Rachelle Yang [:ryang][[e-mail]]]

Hi Peter, 
Could you please help us check this bug?
We are not sure if this is a layout issue. Can you please help ? Thank you very much!

Comment 12

[Peter Chang[:pchang]]

(In reply to Rachelle Yang [:ryang][[e-mail]] from comment #11)
> Hi Peter, 
> Could you please help us check this bug?
> We are not sure if this is a layout issue. Can you please help ? Thank you
> very much!
In comment 5, I think this is related to APZ, not layout issue.

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

Botond, let's see if we can take care of this in the early 53 beta so that we don't ship a regression.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

FWIW since this is a dynamic toolbar-related issue we should probably just wait until Randall does his rewrite. Marking this as a dependency.

Comment 16

[Botond Ballo [:botond] [away until Jun 24]]

(In reply to Milan Sreckovic [:milan] from comment #14)
> Botond, let's see if we can take care of this in the early 53 beta so that
> we don't ship a regression.

Note that this is not a new regression in 53. We have been shipping this regression since 43.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

This is fixed by bug 1335895.