1324385 - Line number of inline style sheets should be absolute, not relative

Status: NEW

(DevTools :: Inspector: Rules, defect, P2)

Description

[Sebastian Zartner [:sebo]]

Attachment: test.html

The line number shown in the source link is relative to the beginning of a style sheet.

For inline style sheets it makes more sense to make this number absolute, i.e. relative to the beginning of the HTML source, not the style sheet, so it's easier to find the line on the server.

FWIW Firebug and the Chrome DevTools show the absolute line number.

Sebastian

Comment 1

[Sebastian Zartner [:sebo]]

Btw. regarding the test case, the Rules side panel shows 'inline' as source while the other tools show 'test.html'. The latter is easier to identify where the source is located. So, this may be changed as well. (Let me know if that deserves a separate bug.)

Related Firebug discussion group thread:
https://groups.google.com/d/topic/firebug/Hel650-is1s/discussion

Sebastian

Comment 2

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 3

[Tom Tromey :tromey]

The line number was made relative by the as-authored change, bug 984880.
I think the story there was that we needed a relative line number so that
edits to the text are done at the correct spot.  However, it seems plausible
to me (without digging too deeply into it) that we could present an absolute
line to the user and keep a relative line internally for editing.

Search for getRelativeRuleLine to see where this is done.

Comment 4

[humancopy]

Attachment: inspector-bug.html

In Firefox 59 it seems to be resolved when there is one inline stylesheet but there's still an issue when there are multiple ones. Though the line number reported is the correct one within the style tag Firefox doesn't open the correct one. Vivaldi for example writes (and links to) the absolute line number from the beginning of the file, and not the relative one.

Comment 5

[humancopy]

Comment on attachment 8970547 [details]
inspector-bug.html

When inspecting the <li> element the list-style-type: square is linking to the correct line but within the wrong style tag.

Comment 6

[Sebastian Zartner [:sebo]]

(In reply to humancopy from comment #4)
> Created attachment 8970547 [details]
> inspector-bug.html
> 
> In Firefox 59 it seems to be resolved when there is one inline stylesheet
> but there's still an issue when there are multiple ones. Though the line
> number reported is the correct one within the style tag Firefox doesn't open
> the correct one.

It is not fixed yet. The line number in my test case is still shown as 2 (i.e. relative) while it should be 6 (absolute).

(In reply to humancopy from comment #5)
> Comment on attachment 8970547 [details]
> inspector-bug.html
> 
> When inspecting the <li> element the list-style-type: square is linking to
> the correct line but within the wrong style tag.

I can reproduce that. Actually, the source links of inline styles only switch to the Style Editor, though they never switch thee style sheet. You can see that by selecting any style sheet within the Style Editor and then click a source link of another one.
Having said that that's a different bug, because it refers to the action of the link while this one refers to its label. So, can you please file a new bug for it (and CC me so I can follow it)?

Sebastian