Closed Bug 1324422 Opened 6 years ago Closed 6 years ago

Crash in mozilla::layers::ClientMultiTiledLayerBuffer::Update

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
Unspecified
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: marcia, Assigned: lsalzman)

References

Details

(Keywords: crash, regression, reproducible)

Crash Data

Attachments

(1 file)

initialize mPermitSubpixelAA for all tiles in DrawTargetTiled
2.06 KB, patch
sotaro
: review+
Details | Diff | Splinter Review 
This bug was filed from the Socorro interface and is 
report bp-70616e2b-b2f9-4f91-98f2-da1d22161219.
=============================================================

Seen while looking at nightly crash stats. This Mac signature began with 20161217030205 and seems to affect Mac and Fennec: http://bit.ly/2h1PQ1D

It is reproducible on my mac with https://learn.javascript.ru/classes

Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=63b447888a6469b9f6ae8f76ac5f0d7c6ea239da&tochange=34a1ab064cb5b868fa75cb74d052e978eb34d6c1
Bug 1322729 is the range. ni on :lsalzman in case he has some ideas.
Flags: needinfo?(lsalzman)
DrawTargetTiled::Init needs to account for tiles that are clipped out?
DrawTargetTiled::Init is reusing the draw targets that are passed in for each tile. In the case these draw targets were used in a previous frame, the PermitSubpixelAA state will essentially be random, and should not be counted on at all.

Instead, call SetPermitSubpixelAA to initialize the state for DTT and all the child tiles to a known value.
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Flags: needinfo?(lsalzman)
Attachment #8820097 - Flags: review?(sotaro.ikeda.g)
Comment on attachment 8820097 [details] [diff] [review]
initialize mPermitSubpixelAA for all tiles in DrawTargetTiled

Looks good.
Attachment #8820097 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07bb0ca0c704
initialize mPermitSubpixelAA for all tiles in DrawTargetTiled. r=sotaro
https://hg.mozilla.org/mozilla-central/rev/07bb0ca0c704
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: 1322729
Keywords: regression
You need to log in before you can comment on or make changes to this bug.