1324422 - Crash in mozilla::layers::ClientMultiTiledLayerBuffer::Update

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-70616e2b-b2f9-4f91-98f2-da1d22161219.
=============================================================

Seen while looking at nightly crash stats. This Mac signature began with 20161217030205 and seems to affect Mac and Fennec: http://bit.ly/2h1PQ1D

It is reproducible on my mac with https://learn.javascript.ru/classes

Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=63b447888a6469b9f6ae8f76ac5f0d7c6ea239da&tochange=34a1ab064cb5b868fa75cb74d052e978eb34d6c1

Comment 1

[Marcia Knous [:marcia]]

Bug 1322729 is the range. ni on :lsalzman in case he has some ideas.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

DrawTargetTiled::Init needs to account for tiles that are clipped out?

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: initialize mPermitSubpixelAA for all tiles in DrawTargetTiled

DrawTargetTiled::Init is reusing the draw targets that are passed in for each tile. In the case these draw targets were used in a previous frame, the PermitSubpixelAA state will essentially be random, and should not be counted on at all.

Instead, call SetPermitSubpixelAA to initialize the state for DTT and all the child tiles to a known value.

Comment 4

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8820097 [details] [diff] [review]
initialize mPermitSubpixelAA for all tiles in DrawTargetTiled

Looks good.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07bb0ca0c704
initialize mPermitSubpixelAA for all tiles in DrawTargetTiled. r=sotaro

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07bb0ca0c704