1324467 - command_id included in capabilities

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

The command_id field is mistakenly included in the session capabilities.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1324467 - Make copy of data to send to listener;

The payload sent to the listener through `GeckoDriver#sendAsync` is
sometimes mutated if a `commandID` parameter is given.  Because `data`
is sometimes a reference to an object, the original object gets modified
with an additional `command_id` field.

To avoid this we copy the object before mutating it and pass it through
to the message manager.

Review commit: https://reviewboard.mozilla.org/r/99552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99552/

Comment 2

[David Burns :automatedtester]

Comment on attachment 8819999 [details]
Bug 1324467 - Make copy of data to send to listener;

https://reviewboard.mozilla.org/r/99552/#review100018

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58614b7c99a7
Make copy of data to send to listener; r=automatedtester

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/58614b7c99a7

Comment 5

[Andreas Tolfsen ❲:ato❳]

Sheriffs: Can you do a test-only uplift of this, please?

Comment 6

[Carsten Book [:Tomcat]]

needs rebasing for uplift

grafting 380324:58614b7c99a7 "Bug 1324467 - Make copy of data to send to listener; r=automatedtester"
merging testing/marionette/driver.js
merging testing/marionette/listener.js
warning: conflicts while merging testing/marionette/driver.js! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 7

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-1324467-Make-copy-of-data-to-send-to-listener-r-.patch

Comment 8

[Andreas Tolfsen ❲:ato❳]

Rebased for Aurora and Beta.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2805e2b6c22f

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa1565d8ff44

Comment 11

[Carsten Book [:Tomcat]]

backed out from beta and aurora for test failurs like https://treeherder.mozilla.org/logviewer.html#?job_id=4537548&repo=mozilla-aurora

Comment 12

[Andreas Tolfsen ❲:ato❳]

I’m going to cancel this uplift as it requires a long list of other uplifts and modifications to apply.

Comment 13

[Andreas Tolfsen ❲:ato❳]

The test failure looks like the result of a faulty rebase to Aurora.  I’m correcting.

Comment 14

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-1324467-Make-copy-of-data-to-send-to-listener-r-.patch

Updated rebased patch for Aurora.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/028c461415da

Comment 16

[Gerry Chang [:gchang]]

Too late for 51. Mark 51 won't fix.