59 bytes, text/x-review-board-request
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=5949456&repo=mozilla-central https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-macosx64/1482157538/mozilla-central_yosemite_r7_test-mochitest-browser-chrome-1-bm136-tests1-macosx-build25.txt.gz
huge spike for this bug in the last 2 days. I have some retriggers on osx debug: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=osx%20bc%20debug%20e10s&tochange=28a77830566502e6b3f2f71581175f4f2bec3b3e&fromchange=96b2668cb9ca691a4514e5a7a16bab5ec0c210cc&selectedJob=74797088 we also see this on win7-vm opt although a lower frequency. this test is timing out, and over the last week on all platforms we complete in <5 seconds, for osx debug it is typically 2-3 seconds. here is a screenshot from osx debug failure: http://mozilla-releng-blobs.s3.amazonaws.com/blobs/mozilla-inbound/sha512/726d9b964b93f5abffd4d76c2944716f5625897ea0f9cb92c7ad01f7681ac327a45a131690f658be2b46841506acc28817143917d5266801ba6f1983a9f28843 and the related log: https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-macosx64-debug/1486394510/mozilla-inbound_yosemite_r7-debug_test-mochitest-e10s-browser-chrome-7-bm106-tests1-macosx-build119.txt.gz I suspect this is failing on line 157: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/test/popupNotifications/browser_popupNotification_checkbox.js?q=path%3Abrowser_popupNotification_checkbox.js&redirect_type=single#157 although it is hard to tell, we get this block from checkMainAction() and stop: 08:57:29 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_checkbox.js | Checkbox should have the correct label - 08:57:29 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_checkbox.js | Checkbox should be shown - 08:57:29 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_checkbox.js | Checkbox should be checked by default - 08:57:29 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_checkbox.js | Warning label should be shown - 08:57:29 INFO - TEST-PASS | browser/base/content/test/popupNotifications/browser_popupNotification_checkbox.js | MainAction should be disabled - I will chime in when the results come in from retriggers. :johannh, I see you are the original patch author, can you look at this sometime this week or next week?
ok, this worked out pretty easy, there are 3 patches which landed and caused this test to start failing: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=579e613faefe :johannh, one you had reviewed (bug 1331524), and another looks like a possibility (bug 1220936).
Interesting, thanks for digging into this. I can not imagine how bug 1331524 could have caused this but I'll investigate.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
This solution is completely unrelated to the patches you mentioned and tbh I have no idea how any of those could have caused this, but I still think it's the right thing to do and I can't reproduce the intermittent locally anymore (took less than 5 runs on --run-until-fail before). I suspect the problem was that the onShown callback of the reshow test was racing with the next test (which is also showing a popupnotification) because onShown did not support generator functions yet. I changed that and added a yield. I'll make a try push with lots of retriggers.
(In reply to Johann Hofmann [:johannh] from comment #5) > I suspect the problem was that the onShown callback of the reshow test was > racing with the next test (which is also showing a popupnotification) > because onShown did not support generator functions yet. I changed that and > added a yield. s/onShown/onHidden
Comment on attachment 8834554 [details] Bug 1324497 - Wait for popupshow to fix intermittent in browser_popupNotification_checkbox.js. https://reviewboard.mozilla.org/r/110438/#review111782 I could swear I had this head.js change in one of my patches at one point, but I must have dropped it for some reason. Thanks!
Attachment #8834554 - Flags: review?(past) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/fe7aa94a46ec Wait for popupshow to fix intermittent in browser_popupNotification_checkbox.js. r=past
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
status-firefox52: --- → affected
status-firefox53: --- → affected
status-firefox53: affected → fixed
status-firefox52: affected → fixed
status-firefox-esr52: --- → fixed
You need to log in before you can comment on or make changes to this bug.