1324524 - Table cells with opacity < 1 can't have collapsed borders

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Loic]

Issue reported here: https://forums.mozfr.org/viewtopic.php?f=5&t=131923

Testcase: http://codepen.io/X-Raym/pen/VmqqLr

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9915ff6e7bf778341f46b5bc095ec46deb673416&tochange=952eae508967ae46d36909d179159f2a2205169c

Andrew Comminos — Bug 1276734 - Use nsDisplayBackgroundImage for table cells without collapsed borders. r=mattwoodrow

Andrew, could you look at this regression, please.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

With only a week left before the 51RC build, marking this fix-optional for 51/52.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Matt, can you help out here? Asking you since there's no triage owner here and you reviewed the original patch. Thanks!

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: border-collapse

It's only safe to use 'normal' background items if we don't have border-collapse. The existing branch had multiple conditions that would allow it to be taken (and opacity triggered one of them) even if it didn't have border-collapse.

It's possible that the event handling condition could use the normal background items, but it's not important for the use case that this was added for, and I'm not confident in our testing of event handling within tables to risk it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88b5a981e275
Make sure we use nsDisplayTableCellbackground for tables with border-collapse. r=tnikkel

Comment 5

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/8160157dcec0 - Win8 was consistently max difference: 2, number of differing pixels: 8258, but figuring out what random pile of %20s amounts to Win8 is above my pay grade.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71227c92ce4f
Make sure we use nsDisplayTableCellbackground for tables with border-collapse. r=tnikkel

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/71227c92ce4f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora/Beta approval on this when you get a chance.

Comment 9

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8834768 [details] [diff] [review]
border-collapse

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1276734
[User impact if declined]: Incorrect table rendering when combining stacking-contexts (opacity) and border-collapse.
[Is this code covered by automated tests?]: Yes, new test added.
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just reverts back to the old behaviour in some cases.
[String changes made/needed]:

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8834768 [details] [diff] [review]
border-collapse

Reverts to pre-49 behavior in some cases to avoid a regression.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/33d9f50b95c5

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Needs a rebased patch for Beta uplift.

Comment 13

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/releases/mozilla-beta/rev/dfab6e1129c8

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/dfab6e1129c8
https://hg.mozilla.org/releases/mozilla-esr52/rev/7db9edbfd87e