1324537 - Implement the OfflineAudioCompletionEvent constructor

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[Andrea Marchesini [:baku]]

https://webaudio.github.io/web-audio-api/#idl-def-OfflineAudioCompletionEvent

Comment 1

[Andrea Marchesini [:baku]]

Attachment: offlineEvent.patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8820153 [details] [diff] [review]
offlineEvent.patch

Why not just implement the whole event using event code generator.
If that was done, OfflineAudioCompletionEvent.h/.cpp could be removed
and only a minor change to
http://searchfox.org/mozilla-central/rev/46ded325e8f60b3d4c731b27c31d383911056a38/dom/media/webaudio/AudioDestinationNode.cpp#134-136 would be needed.

So, make the changes to .webidl and move the .webidl in moz.build to be in
GENERATED_EVENTS_WEBIDL_FILES

Simpler and more future proof.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: offlineEvent.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/534737292c03
Implement the OfflineAudioCompletionEvent constructor, r=smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9902a4f699fb
Implement the OfflineAudioCompletionEvent constructor - part 2, r=me

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/534737292c03
https://hg.mozilla.org/mozilla-central/rev/9902a4f699fb