Implement the OfflineAudioCompletionEvent constructor

RESOLVED FIXED in Firefox 53

Status

()

Core
Web Audio
P2
normal
Rank:
25
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: baku, Assigned: baku)

Tracking

50 Branch
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Comment 1

a year ago
Created attachment 8820153 [details] [diff] [review]
offlineEvent.patch
Assignee: nobody → amarchesini
Attachment #8820153 - Flags: review?(padenot)
Attachment #8820153 - Flags: review?(bugs)
Comment on attachment 8820153 [details] [diff] [review]
offlineEvent.patch

Why not just implement the whole event using event code generator.
If that was done, OfflineAudioCompletionEvent.h/.cpp could be removed
and only a minor change to
http://searchfox.org/mozilla-central/rev/46ded325e8f60b3d4c731b27c31d383911056a38/dom/media/webaudio/AudioDestinationNode.cpp#134-136 would be needed.

So, make the changes to .webidl and move the .webidl in moz.build to be in
GENERATED_EVENTS_WEBIDL_FILES

Simpler and more future proof.
Attachment #8820153 - Flags: review?(bugs) → review-
(Assignee)

Comment 3

a year ago
Created attachment 8820204 [details] [diff] [review]
offlineEvent.patch
Attachment #8820153 - Attachment is obsolete: true
Attachment #8820153 - Flags: review?(padenot)
Attachment #8820204 - Flags: review?(bugs)

Updated

a year ago
Attachment #8820204 - Flags: review?(bugs) → review+

Comment 4

a year ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/534737292c03
Implement the OfflineAudioCompletionEvent constructor, r=smaug

Comment 5

a year ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9902a4f699fb
Implement the OfflineAudioCompletionEvent constructor - part 2, r=me

Updated

a year ago
Status: NEW → ASSIGNED
Rank: 25
Priority: -- → P2

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/534737292c03
https://hg.mozilla.org/mozilla-central/rev/9902a4f699fb
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.