Closed Bug 1324537 Opened 7 years ago Closed 7 years ago

Implement the OfflineAudioCompletionEvent constructor

Categories

(Core :: Web Audio, defect, P2)

50 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch offlineEvent.patch (obsolete) — Splinter Review
Assignee: nobody → amarchesini
Attachment #8820153 - Flags: review?(padenot)
Attachment #8820153 - Flags: review?(bugs)
Comment on attachment 8820153 [details] [diff] [review]
offlineEvent.patch

Why not just implement the whole event using event code generator.
If that was done, OfflineAudioCompletionEvent.h/.cpp could be removed
and only a minor change to
http://searchfox.org/mozilla-central/rev/46ded325e8f60b3d4c731b27c31d383911056a38/dom/media/webaudio/AudioDestinationNode.cpp#134-136 would be needed.

So, make the changes to .webidl and move the .webidl in moz.build to be in
GENERATED_EVENTS_WEBIDL_FILES

Simpler and more future proof.
Attachment #8820153 - Flags: review?(bugs) → review-
Attachment #8820153 - Attachment is obsolete: true
Attachment #8820153 - Flags: review?(padenot)
Attachment #8820204 - Flags: review?(bugs)
Attachment #8820204 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/534737292c03
Implement the OfflineAudioCompletionEvent constructor, r=smaug
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9902a4f699fb
Implement the OfflineAudioCompletionEvent constructor - part 2, r=me
Status: NEW → ASSIGNED
Rank: 25
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/534737292c03
https://hg.mozilla.org/mozilla-central/rev/9902a4f699fb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: