Created attachment 8820153 [details] [diff] [review] offlineEvent.patch
Comment on attachment 8820153 [details] [diff] [review] offlineEvent.patch Why not just implement the whole event using event code generator. If that was done, OfflineAudioCompletionEvent.h/.cpp could be removed and only a minor change to http://searchfox.org/mozilla-central/rev/46ded325e8f60b3d4c731b27c31d383911056a38/dom/media/webaudio/AudioDestinationNode.cpp#134-136 would be needed. So, make the changes to .webidl and move the .webidl in moz.build to be in GENERATED_EVENTS_WEBIDL_FILES Simpler and more future proof.
Attachment #8820153 - Flags: review?(bugs) → review-
Created attachment 8820204 [details] [diff] [review] offlineEvent.patch
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/534737292c03 Implement the OfflineAudioCompletionEvent constructor, r=smaug
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9902a4f699fb Implement the OfflineAudioCompletionEvent constructor - part 2, r=me
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.