Closed
Bug 1324537
Opened 7 years ago
Closed 7 years ago
Implement the OfflineAudioCompletionEvent constructor
Categories
(Core :: Web Audio, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file, 1 obsolete file)
10.91 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8820153 -
Flags: review?(padenot)
Attachment #8820153 -
Flags: review?(bugs)
Comment 2•7 years ago
|
||
Comment on attachment 8820153 [details] [diff] [review] offlineEvent.patch Why not just implement the whole event using event code generator. If that was done, OfflineAudioCompletionEvent.h/.cpp could be removed and only a minor change to http://searchfox.org/mozilla-central/rev/46ded325e8f60b3d4c731b27c31d383911056a38/dom/media/webaudio/AudioDestinationNode.cpp#134-136 would be needed. So, make the changes to .webidl and move the .webidl in moz.build to be in GENERATED_EVENTS_WEBIDL_FILES Simpler and more future proof.
Attachment #8820153 -
Flags: review?(bugs) → review-
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8820153 -
Attachment is obsolete: true
Attachment #8820153 -
Flags: review?(padenot)
Attachment #8820204 -
Flags: review?(bugs)
Updated•7 years ago
|
Attachment #8820204 -
Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/534737292c03 Implement the OfflineAudioCompletionEvent constructor, r=smaug
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9902a4f699fb Implement the OfflineAudioCompletionEvent constructor - part 2, r=me
Updated•7 years ago
|
Status: NEW → ASSIGNED
Rank: 25
Priority: -- → P2
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/534737292c03 https://hg.mozilla.org/mozilla-central/rev/9902a4f699fb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•