1324557 - Add stats collection into each sync engine to keep track of record operation at a finer grained level (excluding bookmarks)

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect, P1)

Description

[Stephan Leroux [:sleroux]]

Part of the Sync Ping requires us to keep track at a more fine grained level of what is happening within our engines. Specifically, we need to know numbers records we were able to apply or fail. Along the way we should also bundle up any kind of errors we run into.

A proposed solution:

- Define a new tracker object which holds onto data for an engine's sync session
- Create a new tracker instance within the scope of each sync call which gets passed along the syncing process and updated along the way.
- Bubble up the tracker and it's information within an EngineResult so we can forward it to the Telemetry system

Comment 1

[Richard Newman [:rnewman]]

Let's not call these 'trackers'. Call them 'stats' or something!

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: WIP

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8827199 [details] [review]
WIP

Re-flagging for feedback

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8827199 [details] [review]
WIP

This patch has been long running because of the Swift 3 migration delay and is already ~600 lines of changes with some unit tests. I've modified this bug to exclude bookmark stats tracking and work on that as a separate issue since that is pretty large by itself.

Bookmark follow up work: https://bugzilla.mozilla.org/show_bug.cgi?id=1324558

Comment 5

[Stephan Leroux [:sleroux]]

Also, I found myself extending this branch with other bug work so I figured it would be best to break it up into smaller PRs.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8827199 [details] [review]
WIP

Review comments on GH.

Comment 7

[Stephan Leroux [:sleroux]]

master 3f0993bb014514a5de56c667703992c01db91e29