Implement AudioScheduledSourceNode

RESOLVED FIXED in Firefox 53

Status

()

defect
P2
normal
Rank:
25
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: baku, Assigned: baku)

Tracking

({dev-doc-complete})

50 Branch
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

Assignee

Comment 1

2 years ago
Assignee: nobody → amarchesini
Attachment #8820042 - Flags: review?(padenot)

Updated

2 years ago
Rank: 25
Priority: -- → P2
Comment on attachment 8820042 [details] [diff] [review]
AudioScheduledSourceNode.patch

Review of attachment 8820042 [details] [diff] [review]:
-----------------------------------------------------------------

No test ? Although I suppose this is tested by the idl test for the Web Audio API when we'll update them base on the interface definitions.
Attachment #8820042 - Flags: review?(padenot) → review+

Comment 3

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d70b97db8d9e
Implement AudioScheduledSourceNode, r=padenot

Comment 4

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/148d51601e2b
Implement AudioScheduledSourceNode - part 2, r=me
Backed out for failing webaudioeditor devtools tests like test/browser_audionode-actor-bypass.js:

Bug 1324352:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a3a17725724d71bd5906d44018da99e42e9cad8

Bug 1324568:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee212f486d788dc8343605f9e364b654834854b
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf74c90bff441b33a29e2a15a41e83b551851dc7

Bug 1324659:
https://hg.mozilla.org/integration/mozilla-inbound/rev/faf170d0bdba2f09f6b5875099a930109591fd14

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f350bbf9e6363a685520b2ad9ba8071f6eebfd07
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=40827534&repo=mozilla-inbound

[task 2016-12-20T20:13:00.006985Z] 20:13:00     INFO - [1627] WARNING: Audio Buffer is not full by the end of the callback.: 'Available() == 0 || mSampleWriteOffset == 0', file /home/worker/workspace/build/src/dom/media/AudioBufferUtils.h, line 88
[task 2016-12-20T20:13:01.277772Z] 20:13:01     INFO - ++DOCSHELL 0x7f67fb30b000 == 10 [pid = 1627] [id = {f9f7e02a-19af-475c-9af7-85c14d9a869b}]
[task 2016-12-20T20:13:01.277890Z] 20:13:01     INFO - ++DOMWINDOW == 25 (0x7f67fb310000) [pid = 1627] [serial = 25] [outer = (nil)]
[task 2016-12-20T20:13:01.279748Z] 20:13:01     INFO - ++DOMWINDOW == 26 (0x7f67fb31d000) [pid = 1627] [serial = 26] [outer = 0x7f67fb310000]
[task 2016-12-20T20:13:01.295432Z] 20:13:01     INFO - ++DOMWINDOW == 27 (0x7f6800f6b000) [pid = 1627] [serial = 27] [outer = 0x7f67fb310000]
[task 2016-12-20T20:13:01.320296Z] 20:13:01     INFO - ++DOCSHELL 0x7f6800f58800 == 11 [pid = 1627] [id = {ee1c0fa0-4b5f-43f1-95fc-0637e5e50c3f}]
[task 2016-12-20T20:13:01.321263Z] 20:13:01     INFO - ++DOMWINDOW == 28 (0x7f6802286000) [pid = 1627] [serial = 28] [outer = (nil)]
[task 2016-12-20T20:13:01.356084Z] 20:13:01     INFO - ++DOMWINDOW == 29 (0x7f67fb147800) [pid = 1627] [serial = 29] [outer = 0x7f6802286000]
[task 2016-12-20T20:13:04.683547Z] 20:13:04     INFO - --DOCSHELL 0x7f680a983000 == 10 [pid = 1627] [id = {45d20fa8-0ac8-4107-97e5-ee669183ff49}]
[task 2016-12-20T20:13:15.017220Z] 20:13:15     INFO - --DOMWINDOW == 28 (0x7f68025dd000) [pid = 1627] [serial = 19] [outer = (nil)] [url = about:blank]
[task 2016-12-20T20:13:15.017371Z] 20:13:15     INFO - --DOMWINDOW == 27 (0x7f6800fd4000) [pid = 1627] [serial = 21] [outer = (nil)] [url = about:blank]
[task 2016-12-20T20:13:15.017450Z] 20:13:15     INFO - --DOMWINDOW == 26 (0x7f680a539800) [pid = 1627] [serial = 9] [outer = (nil)] [url = about:blank]
[task 2016-12-20T20:13:15.017543Z] 20:13:15     INFO - --DOMWINDOW == 25 (0x7f6818f16000) [pid = 1627] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2016-12-20T20:13:15.018964Z] 20:13:15     INFO - --DOMWINDOW == 24 (0x7f68163da800) [pid = 1627] [serial = 23] [outer = (nil)] [url = http://example.com/browser/devtools/client/webaudioeditor/test/doc_simple-context.html]
[task 2016-12-20T20:13:15.019051Z] 20:13:15     INFO - --DOMWINDOW == 23 (0x7f67fb31d000) [pid = 1627] [serial = 26] [outer = (nil)] [url = about:blank]
[task 2016-12-20T20:13:16.826351Z] 20:13:16     INFO - --DOMWINDOW == 22 (0x7f680a983800) [pid = 1627] [serial = 8] [outer = (nil)] [url = about:blank]
[task 2016-12-20T20:13:21.946723Z] 20:13:21     INFO - --DOMWINDOW == 21 (0x7f6805e9d000) [pid = 1627] [serial = 13] [outer = (nil)] [url = about:blank]
[task 2016-12-20T20:13:21.947272Z] 20:13:21     INFO - --DOMWINDOW == 20 (0x7f680a355000) [pid = 1627] [serial = 12] [outer = (nil)] [url = about:blank]
[task 2016-12-20T20:13:43.803055Z] 20:13:43     INFO - TEST-INFO | started process screentopng
[task 2016-12-20T20:13:44.296904Z] 20:13:44     INFO - TEST-INFO | screentopng: exit 0
[task 2016-12-20T20:13:44.297150Z] 20:13:44     INFO - Buffered messages logged at 20:12:58
[task 2016-12-20T20:13:44.297309Z] 20:13:44     INFO - Entering test bound 
[task 2016-12-20T20:13:44.297993Z] 20:13:44     INFO - Initializing a web audio editor front.
[task 2016-12-20T20:13:44.300684Z] 20:13:44     INFO - Adding tab: http://example.com/browser/devtools/client/webaudioeditor/test/doc_simple-context.html
[task 2016-12-20T20:13:44.300801Z] 20:13:44     INFO - Buffered messages logged at 20:12:59
[task 2016-12-20T20:13:44.301309Z] 20:13:44     INFO - Tab added and finished loading: http://example.com/browser/devtools/client/webaudioeditor/test/doc_simple-context.html
[task 2016-12-20T20:13:44.301373Z] 20:13:44     INFO - Waiting for 3 create-node events
[task 2016-12-20T20:13:44.302286Z] 20:13:44     INFO - Buffered messages finished
[task 2016-12-20T20:13:44.302440Z] 20:13:44     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js | Test timed out - 
[task 2016-12-20T20:13:44.302554Z] 20:13:44     INFO - finish() was called, cleaning up...
[task 2016-12-20T20:13:44.435638Z] 20:13:44     INFO - MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2016-12-20T20:13:44.435880Z] 20:13:44     INFO - MEMORY STAT | vsize 1131MB | residentFast 251MB | heapAllocated 88MB
[task 2016-12-20T20:13:44.436072Z] 20:13:44     INFO - TEST-OK | devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js | took 45972ms
[task 2016-12-20T20:13:44.437750Z] 20:13:44     INFO - Not taking screenshot here: see the one that was previously logged
[task 2016-12-20T20:13:44.439613Z] 20:13:44     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js | Found a tab after previous test timed out: http://example.com/browser/devtools/client/webaudioeditor/test/doc_simple-context.html -
Flags: needinfo?(amarchesini)

Comment 7

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a454e4dae7b9
Implement AudioScheduledSourceNode, r=padenot

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a454e4dae7b9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee

Updated

2 years ago
Flags: needinfo?(amarchesini)
Adding dev-doc-needed so this gets onto the docs radar for 53 (which we're actively documenting now).
Keywords: dev-doc-needed
Documentation added:

https://developer.mozilla.org/en-US/docs/Web/API/AudioScheduledSourceNode
https://developer.mozilla.org/en-US/docs/Web/API/AudioScheduledSourceNode/start
https://developer.mozilla.org/en-US/docs/Web/API/AudioScheduledSourceNode/stop
https://developer.mozilla.org/en-US/docs/Web/API/AudioScheduledSourceNode/onended

Documentation updated:

https://developer.mozilla.org/en-US/Firefox/Releases/53

HOWEVER, there are still other documents that need updating. OscillatorNode etc need reviewing to be sure they're fully updated to reflect the change in parent. This will mean removing the foo/onended, foo/start, and foo/stop pages and ensuring that any special information contained in them is reflected in the correct places.
Now also updated:

https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode
https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/start
https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/loop
https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/loopStart
https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/loopEnd

https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/stop now redirects to https://developer.mozilla.org/en-US/docs/Web/API/AudioScheduledSourceNode/stop

Similarly, all pages in OscillatorNode have been updated, and I while handling bug 1308432 I went ahead and just wrote the documentation for ConstantSourceNode being based on AudioScheduledSourceNode from the beginning to save time.

This is now complete as far as I can tell; please let me know if you find any issues with the documentation content.
You need to log in before you can comment on or make changes to this bug.