1324677 - stylo: several tests non-fatally assert with "expected ServoData to be cleared earlier"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

###!!! ASSERTION: expected ServoData to be cleared earlier: '!HasServoData()', file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/Element.h, line 172

  layout/style/crashtests/1146101-1.html
  layout/style/crashtests/1264396-1.html
  layout/svg/crashtests/361587-1.svg

Comment 1

[Cameron McCormack (:heycam)]

These tests no longer assert.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1324677 - Remove unnecessary asserts-if(stylo) annotation from layout crashtests.

These tests no longer assert so we can remove the stylo annotations.

Review commit: https://reviewboard.mozilla.org/r/176692/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/176692/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8904901 [details]
Bug 1324677 - Remove unnecessary asserts-if(stylo) annotation from layout crashtests.

https://reviewboard.mozilla.org/r/176692/#review181660

Ah, I forgot to remove these.  Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36b32026b08d
Remove unnecessary asserts-if(stylo) annotation from layout crashtests. r=heycam

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/36b32026b08d