1324693 - stylo: several tests non-fatally assert with a few animation related assertions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Cameron McCormack (:heycam)]

###!!! ASSERTION: stylo: Servo-backed style system should not be using EffectCompositor: 'Error', file /home/worker/workspace/build/src/dom/animation/EffectCompositor.cpp, line 279
###!!! ASSERTION: stylo: ServoRestyleManager does not support animations yet: 'Error', file /home/worker/workspace/build/src/layout/generic/nsFrame.cpp, line 710
###!!! ASSERTION: stylo: cannot handle compositor-driven animations yet: 'Error', file /home/worker/workspace/build/src/dom/animation/EffectCompositor.cpp, line 153

  dom/animation/test/crashtests/1216842-5.html
  dom/animation/test/crashtests/1216842-6.html
  dom/animation/test/crashtests/1272475-1.html
  dom/animation/test/crashtests/1272475-2.html

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1324693 - Make parse_dimension() return a finite value.

We use parse_dimension() to parse specified::Angle, and it is possible
to input an extra large angle, e.g. rotate(9.5e+307rad), so we need to
clamp it to avoid any assertion in Gecko.

Review commit: https://reviewboard.mozilla.org/r/123820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123820/

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1324693 - Enable crashtests, 1272475-1.html and 1272475-2.html.

Review commit: https://reviewboard.mozilla.org/r/123822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123822/

Comment 3

[Boris Chiou [:boris]]

Wrong bug number....

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8851505 [details]
Bug 1324693 - Make parse_dimension() return a finite value.

https://reviewboard.mozilla.org/r/123820/#review126220

::: servo/components/style/values/specified/mod.rs:221
(Diff revision 1)
>          }
>          _ => Err(())
>      }
>  }
>  
>  #[allow(missing_docs)]

I don't think you need this on a non-pub fn.

Comment 5

[Boris Chiou [:boris]]

(In reply to Cameron McCormack (:heycam) from comment #4)
> Comment on attachment 8851505 [details]
> Bug 1324693 - Make parse_dimension() return a finite value.
> 
> https://reviewboard.mozilla.org/r/123820/#review126220
> 
> ::: servo/components/style/values/specified/mod.rs:221
> (Diff revision 1)
> >          }
> >          _ => Err(())
> >      }
> >  }
> >  
> >  #[allow(missing_docs)]
> 
> I don't think you need this on a non-pub fn.

OK. I would like to move these patches into another bug, and I will remove this non-pub fn.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Fixed by bug 1336769.