1324705 - stylo: several tests non-fatally assert with "wrong kind of child frame"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

###!!! ASSERTION: wrong kind of child frame: 'aIsBlock == f->IsBlockOutside()', file /home/worker/workspace/build/src/layout/generic/nsLineBox.cpp, line 60

  layout/base/crashtests/866588.html
  layout/base/crashtests/942690.html
  layout/generic/crashtests/534366-1.html
  layout/generic/crashtests/534366-2.html
  layout/style/crashtests/466845-1.html

These all have ::first-line in them.

Comment 1

[Cameron McCormack (:heycam)]

These all seem to be fixed by https://github.com/servo/servo/pull/14922.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1324705 - stylo: Update some crashtest assertion expectations.

These were fixed by https://github.com/servo/servo/pull/14922.

Review commit: https://reviewboard.mozilla.org/r/103266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/103266/

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8824928 [details]
Bug 1324705 - stylo: Update some crashtest assertion expectations.

https://reviewboard.mozilla.org/r/103266/#review103756

Hmm... Do we compute `::first-line` as a lazy pseudo, don't we? I don't understand how could that patch fix it.


Oh, of course, `::-moz-text`, never mind (keeping the previous comment just in case someone wondered the same).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b04dd836a22b
stylo: Update some crashtest assertion expectations. r=emilio

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b04dd836a22b