Closed Bug 1324705 Opened 4 years ago Closed 4 years ago

stylo: several tests non-fatally assert with "wrong kind of child frame"

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: heycam, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

###!!! ASSERTION: wrong kind of child frame: 'aIsBlock == f->IsBlockOutside()', file /home/worker/workspace/build/src/layout/generic/nsLineBox.cpp, line 60

  layout/base/crashtests/866588.html
  layout/base/crashtests/942690.html
  layout/generic/crashtests/534366-1.html
  layout/generic/crashtests/534366-2.html
  layout/style/crashtests/466845-1.html

These all have ::first-line in them.
These all seem to be fixed by https://github.com/servo/servo/pull/14922.
Comment on attachment 8824928 [details]
Bug 1324705 - stylo: Update some crashtest assertion expectations.

https://reviewboard.mozilla.org/r/103266/#review103756

Hmm... Do we compute `::first-line` as a lazy pseudo, don't we? I don't understand how could that patch fix it.


Oh, of course, `::-moz-text`, never mind (keeping the previous comment just in case someone wondered the same).
Attachment #8824928 - Flags: review?(emilio+bugs) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b04dd836a22b
stylo: Update some crashtest assertion expectations. r=emilio
https://hg.mozilla.org/mozilla-central/rev/b04dd836a22b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.