Fix failures in unit test test_typing.py for Fennec

RESOLVED FIXED in Firefox 52

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: whimboo, Unassigned)

Tracking

Version 3
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

Attachments

(1 attachment)

Chunk 7 of Marionette tests for Fennec show two failures in the unit test test_typing.py:

TEST-UNEXPECTED-ERROR | test_typing.py TestTyping.testCutAndPasteShortcuts | NoSuchElementException: Unable to locate element: urlbar
TEST-UNEXPECTED-FAIL | test_typing.py TestTyping.testShouldReportKeyCodeOfArrowKeysUpDownEvents | AssertionError: False is not true

The first is clear because there is no urlbar present. For the latter I would have to check what's supported on the Andoid device.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Attachment #8820233 - Flags: review?(mjzffr)
Comment on attachment 8820233 [details]
Bug 1324725 - Refactor test_typing.py to pass for Fennec.

https://reviewboard.mozilla.org/r/99770/#review100270
Attachment #8820233 - Flags: review?(mjzffr) → review+

Comment 5

3 years ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ed23b4a43cc
Refactor test_typing.py to pass for Fennec. r=maja_zf

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8ed23b4a43cc
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Test-only patch which we would like to have for the next ESR. Please uplift to aurora. Thanks.
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.