1324725 - Fix failures in unit test test_typing.py for Fennec

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Chunk 7 of Marionette tests for Fennec show two failures in the unit test test_typing.py:

TEST-UNEXPECTED-ERROR | test_typing.py TestTyping.testCutAndPasteShortcuts | NoSuchElementException: Unable to locate element: urlbar
TEST-UNEXPECTED-FAIL | test_typing.py TestTyping.testShouldReportKeyCodeOfArrowKeysUpDownEvents | AssertionError: False is not true

The first is clear because there is no urlbar present. For the latter I would have to check what's supported on the Andoid device.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1324725 - Refactor test_typing.py to pass for Fennec.

Review commit: https://reviewboard.mozilla.org/r/99770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99770/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8820233 [details]
Bug 1324725 - Refactor test_typing.py to pass for Fennec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99770/diff/1-2/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8820233 [details]
Bug 1324725 - Refactor test_typing.py to pass for Fennec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99770/diff/2-3/

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8820233 [details]
Bug 1324725 - Refactor test_typing.py to pass for Fennec.

https://reviewboard.mozilla.org/r/99770/#review100270

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ed23b4a43cc
Refactor test_typing.py to pass for Fennec. r=maja_zf

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8ed23b4a43cc

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Test-only patch which we would like to have for the next ESR. Please uplift to aurora. Thanks.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d6ae871ef73b