[RTL] Fix camera icon on Toolbox Options

RESOLVED FIXED in Firefox 53

Status

DevTools
Framework
P3
normal
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: tomer, Assigned: tomer)

Tracking

(Blocks: 1 bug, {rtl})

unspecified
Firefox 53
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

(URL)

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Created attachment 8820220 [details]
Camera icon on Toolbox Options screenshot

The fix for bug 1323504 introduced a problem with the camera icon. Because this change involves changing the common.css file, I am using this bug to track the changes. 



chrome://devtools/content/framework/toolbox-options.xhtml
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8820222 [details]
Bug 1324746 [RTL] Fix camera icon on Toolbox Options

https://reviewboard.mozilla.org/r/99746/#review100218

Thanks for the patch!

::: devtools/client/themes/common.css:284
(Diff revision 1)
>  
>  .devtools-button::before {
>    content: "";
>    display: block;
>    position: absolute;
> -  left: 50%;
> +  offset-inline-start: 50%;

Shouldn't we use offset-block start instead of top to be consistent?

This fixes the camera-icon but it took me a while to understand why. The top/left 50% + negative margins is a pattern used for centering absolutely positioned elements, and by itself doesn't need to use logical properties.

But here the margin-inline-start: -8px now gets overridden by http://searchfox.org/mozilla-central/source/devtools/client/framework/options-panel.css#111 . Before it was only overridden in LTR, when margin-left ~= margin-inline-start.

I don't think the icon position should be adjusted by overriding margins the ::before pseudo, but that's not related to your changeset.
Attachment #8820222 - Flags: review?(jdescottes) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2122bed2f2ff
[RTL] Fix camera icon on Toolbox Options r=jdescottes
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2122bed2f2ff
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Comment 7

2 years ago
Working fine in latest Nightly.

Comment 8

a year ago
I have reproduced this bug with Firefox nightly 53.0a1 (2016-12-20)on Windows 10, 64 Bit.

The Bug's fix is now verified on latest Beta 53.0b3 !

Build ID 	20170316045436
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[testday-20170317]

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.