1324760 - Expose a function that clears plugin data in sanitize.js

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[Bob Silverberg [:bsilverberg]]

The browsingData WebExtensions API [1] needs to be able to remove plugin data, and only plugin data. It can use the same code that is currently in promiseClearPluginCookies in sanitize.js [2] and rather than copy all of that code into ext-browsingData.js if we change sanitize.js to expose a method that just clears plugin data we can use that. Currently the code to clear plugin data is embedded inside cookies.clear(), so it needs to be extracted and exposed. This bug is about doing that.

I discussed a number of options for this with mak in IRC and we decided that making the change to sanitize.js was the best route at this time.

[1] https://developer.chrome.com/extensions/browsingData#method-removePluginData
[2] http://searchfox.org/mozilla-central/source/browser/base/content/sanitize.js#314

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1324760 - Expose a function that clears plugin data in sanitize.js,

Review commit: https://reviewboard.mozilla.org/r/99846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99846/

Comment 2

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8820340 [details]
Bug 1324760 - Expose a function that clears plugin data in sanitize.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99846/diff/1-2/

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8820340 [details]
Bug 1324760 - Expose a function that clears plugin data in sanitize.js,

https://reviewboard.mozilla.org/r/99846/#review100678

mostly code move, the only downside is that with certain input strings, like both cookies and pluginData, it may end up double clearing plugin data... but not a big deal and in practice it's unlikely to happen.

Comment 4

[Bob Silverberg [:bsilverberg]]

Thanks Marco. Try is happy as well, so requesting check in.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7f5da2f308a
Expose a function that clears plugin data in sanitize.js, r=mak

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f7f5da2f308a