Last Comment Bug 132485 - built-in root certs slot description is empty
: built-in root certs slot description is empty
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.4
: All All
P2 normal (vote)
: 3.12
Assigned To: Julien Pierre
Depends on:
  Show dependency treegraph
Reported: 2002-03-20 19:46 PST by Julien Pierre
Modified: 2007-07-10 15:35 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Add a string (1.03 KB, patch)
2007-07-05 20:02 PDT, Julien Pierre
nelson: review+
rrelyea: superreview+
Details | Diff | Splinter Review

Description User image Julien Pierre 2002-03-20 19:46:03 PST
From mozilla/security/nss/lib/ckfw/builtins/constants.c :

nss_builtins_SlotDescription = (NSSUTF8 *) "";

This causes the slot to show up as blank in modutil . Don't we want something
listed there ?
Comment 1 User image Wan-Teh Chang 2002-04-25 16:27:31 PDT
Changed the QA contact to Bishakha.
Comment 2 User image Wan-Teh Chang 2002-05-08 17:00:28 PDT
Set target milestone to NSS 3.5.
Comment 3 User image Wan-Teh Chang 2002-10-29 14:29:54 PST
Bob, what should the slot description for the
builtins be?
Comment 4 User image Wan-Teh Chang 2002-12-06 11:11:12 PST
Moved to target milestone 3.8 because the original
NSS 3.7 release has been renamed 3.8.
Comment 5 User image Nelson Bolyard (seldom reads bugmail) 2003-05-09 21:15:08 PDT
Remove target milestone of 3.8, since these bugs didn't get into that release.
Comment 6 User image Julien Pierre 2007-07-05 20:02:09 PDT
Created attachment 271171 [details] [diff] [review]
Add a string
Comment 7 User image Nelson Bolyard (seldom reads bugmail) 2007-07-05 20:15:36 PDT
Comment on attachment 271171 [details] [diff] [review]
Add a string

Maybe "NSS Builtin Root certs" ?
I want to ask Bob for SR on this, in case there is any inobvious effect of this change.
Comment 8 User image Robert Relyea 2007-07-06 11:45:40 PDT
Comment on attachment 271171 [details] [diff] [review]
Add a string


though I do like the idea of including the words 'Root Certs' in the module name.
If the string is changed, be sure it fits in 32 bytes.
Comment 9 User image Julien Pierre 2007-07-10 15:35:40 PDT
Nelson, Bob, thanks for the reviews. I checked this in on the trunk.

Checking in constants.c;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/constants.c,v  <--  constants.c
new revision: 1.12; previous revision: 1.11

Note You need to log in before you can comment on or make changes to this bug.