built-in root certs slot description is empty

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
15 years ago
10 years ago

People

(Reporter: Julien Pierre, Assigned: Julien Pierre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.03 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Robert Relyea
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
From mozilla/security/nss/lib/ckfw/builtins/constants.c :

NSS_IMPLEMENT_DATA const NSSUTF8 *
nss_builtins_SlotDescription = (NSSUTF8 *) "";

This causes the slot to show up as blank in modutil . Don't we want something
listed there ?
(Assignee)

Updated

15 years ago
Priority: -- → P2
Target Milestone: --- → 3.4.1

Comment 1

15 years ago
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee

Comment 2

15 years ago
Set target milestone to NSS 3.5.
Target Milestone: 3.4.1 → 3.5
(Assignee)

Updated

15 years ago
Target Milestone: 3.5 → 3.6

Comment 3

15 years ago
Bob, what should the slot description for the
builtins be?
Target Milestone: 3.6 → 3.7

Comment 4

15 years ago
Moved to target milestone 3.8 because the original
NSS 3.7 release has been renamed 3.8.
Target Milestone: 3.7 → 3.8
Remove target milestone of 3.8, since these bugs didn't get into that release.
Target Milestone: 3.8 → ---
QA Contact: bishakhabanerjee → jason.m.reid
Assignee: wtchang → nobody
QA Contact: jason.m.reid → libraries
(Assignee)

Updated

10 years ago
Assignee: nobody → julien.pierre.boogz
(Assignee)

Comment 6

10 years ago
Created attachment 271171 [details] [diff] [review]
Add a string
Attachment #271171 - Flags: review?(nelson)
(Assignee)

Updated

10 years ago
Target Milestone: --- → 3.12
Comment on attachment 271171 [details] [diff] [review]
Add a string

Maybe "NSS Builtin Root certs" ?
I want to ask Bob for SR on this, in case there is any inobvious effect of this change.
Attachment #271171 - Flags: superreview?(rrelyea)
Attachment #271171 - Flags: review?(nelson)
Attachment #271171 - Flags: review+

Comment 8

10 years ago
Comment on attachment 271171 [details] [diff] [review]
Add a string

sr=relyea.

though I do like the idea of including the words 'Root Certs' in the module name.
If the string is changed, be sure it fits in 32 bytes.
Attachment #271171 - Flags: superreview?(rrelyea) → superreview+
(Assignee)

Comment 9

10 years ago
Nelson, Bob, thanks for the reviews. I checked this in on the trunk.

Checking in constants.c;
/cvsroot/mozilla/security/nss/lib/ckfw/builtins/constants.c,v  <--  constants.c
new revision: 1.12; previous revision: 1.11
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.