1324868 - Fix Narrate telemetry to record initializations

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Eitan Isaacson [:eeejay]]

The `initial` flag in NarrateControls._setupVoices was mistakenly inverted.

Comment 1

[Eitan Isaacson [:eeejay]]

This renders the data we got so far as junk. If we can push a fix forward to beta before merge to release, we will get accurate data in the release channel.

Benjamin, would that be the correct course? Sorry for this screwup. We can also discontinue that histogram name.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value.

Review commit: https://reviewboard.mozilla.org/r/99874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99874/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8820376 [details]
Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value.

https://reviewboard.mozilla.org/r/99874/#review100316

D'oh. Sorry for missing this in the original review.

Comment 4

[Benjamin Smedberg]

You are welcome to rename the histogram (e.g. "_2") if that would help your analysis. Do whatever is better for you, no additional data review needed for that.

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 8820376 [details]
Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value.

Gijs,

Can you give this one last glance with the telemetry rename? I want to push this up to beta, so another set of eyes is good.

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8820376 [details]
Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99874/diff/1-2/

Comment 7

[:Gijs (he/him)]

Comment on attachment 8820376 [details]
Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value.

(In reply to Eitan Isaacson [:eeejay] from comment #5)
> Comment on attachment 8820376 [details]
> Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to
> correct value.
> 
> Gijs,
> 
> Can you give this one last glance with the telemetry rename? I want to push
> this up to beta, so another set of eyes is good.

Sure, wfm.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ee2f4620247
invert `initial` flag in NarrateContols._setupVoices to correct value. r=Gijs

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9ee2f4620247

Comment 10

[Eitan Isaacson [:eeejay]]

Comment on attachment 8820376 [details]
Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value.

Approval Request Comment
[Feature/Bug causing the regression]: 1308030
[User impact if declined]: We won't have a useful metric for language support in Narrate.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It is a simple rename of a telemetry histogram, and a one line change that affects telemetry only and not anything user facing.
[String changes made/needed]: None.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8820376 [details]
Bug 1324868 - invert `initial` flag in NarrateContols._setupVoices to correct value.

OK to uplift to aurora and beta, looks like a simple fix verified in nightly.
This should make it into the Beta 11 build on Jan. 2.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5ae4b9494db7

Comment 13

[Carsten Book [:Tomcat]]

needs rebasing for beta

Comment 14

[Eitan Isaacson [:eeejay]]

My mistake. I thought this was already in beta, it is not. No need for uplift. Aurora is all we need.