Port bug 1322414 (remove content-primary) to DOM Inspector

RESOLVED FIXED in 2.0

Status

Other Applications
DOM Inspector
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

a year ago
DOMi has a content-primary in resources\content\inspectorOverlay.xul.
Bug 1322414 basically changed this to type="content" primary="true".

This needs to be ported to the current DOMi for SeaMonkey 2.50+ and any gecko 53+ application.
(Assignee)

Comment 1

a year ago
Created attachment 8820410 [details] [diff] [review]
1324899-DOMiContentPrimary.patch

Changing content-primary and adjusting min version numbers. Setting version to 2.0.18.0 so that it updates when bundled with SeaMonkey. 

Not taking the bug yet. I am unhappy with the patch because this would make it incompatible with older versions and PM. Maybe type and primary can be set depending on version number?
Attachment #8820410 - Flags: feedback?(philip.chee)
(Assignee)

Comment 2

a year ago
Created attachment 8820736 [details] [diff] [review]
1324899-DOMiContentPrimary-V2.patch

This does it for me and preserves compatibility. 

Tested with SeaMonkey 2.50a1 and 2.49a2.
Assignee: nobody → frgrahl
Attachment #8820410 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8820410 - Flags: feedback?(philip.chee)
Attachment #8820736 - Flags: review?(philip.chee)
(Assignee)

Comment 3

a year ago
Ian,

can you put up a new version on AMO? Instead of 2.0.18.0 I am thinking of 2.0.17.0. Rationale for the last minor version is the same as for debugQA. If it changes it will autoupdate when bundled with a Nightly Seamonkey.
Flags: needinfo?(iann_bugzilla)

Comment 4

a year ago
(In reply to Frank-Rainer Grahl from comment #3)
Also see "Bug 1324196 - DOM Inspector 2.0.16.1-signed only compatible until SeaMonkey 2.39"
See Also: → bug 1324196

Comment 5

a year ago
(In reply to Frank-Rainer Grahl from comment #3)
> Ian,
> 
> can you put up a new version on AMO? Instead of 2.0.18.0 I am thinking of
> 2.0.17.0. Rationale for the last minor version is the same as for debugQA.
> If it changes it will autoupdate when bundled with a Nightly Seamonkey.

That would be mcsmurf, ewong, callek or KaiRo I think.
Flags: needinfo?(iann_bugzilla)

Comment 6

a year ago
Comment on attachment 8820736 [details] [diff] [review]
1324899-DOMiContentPrimary-V2.patch

> +  if (Services.vc.compare(Services.appinfo.platformVersion, "53.0a1") < 0) {
> +    let ifBrowser = document.getElementById("ifBrowser");
> +    ifBrowser.removeAttribute("primary");
> +    ifBrowser.setAttribute("type", "content-primary");

No need to remove "primary" attribute since it means nothing for Gecko < 53
Hence we can simplify:
document.getElementById("ifBrowser").setAttribute("type", "content-primary");

For uploading to AMO please ask mcsmurf.
Attachment #8820736 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 7

a year ago
Created attachment 8822941 [details] [diff] [review]
1324899-DOMiContentPrimary-V3.patch

Fixed Patch. Tested with 2.48 and 2.50a1.

Current DOMi on AMO is 2.0.16.1 so I put 2.0.17.0 in the patch. 

Review+ from Philip Chee carried forward.
Attachment #8820736 - Attachment is obsolete: true
Attachment #8822941 - Flags: review+
(Assignee)

Comment 8

a year ago
https://hg.mozilla.org/dom-inspector/rev/a69769cacd8dbf7b2d41ff361c25d3712c72355d

If you installed the 2.0.18.0 xpi from the previous patch please install the 2.0.17.0 xpi manually again.
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0
(Assignee)

Comment 9

a year ago
Callek,

die you find the AMO password and could you give it to a council member?
Flags: needinfo?(bugspam.Callek)
(In reply to Frank-Rainer Grahl from comment #9)
> Callek,
> 
> die you find the AMO password and could you give it to a council member?

I did not find it yet, will leave the n-i open so I can try and squeeze looking into my agenda this week.
(Assignee)

Updated

11 months ago
Flags: needinfo?(bugspam.Callek)
You need to log in before you can comment on or make changes to this bug.