1324899 - Port bug 1322414 (remove content-primary) to DOM Inspector

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Frank-Rainer Grahl (:frg)]

DOMi has a content-primary in resources\content\inspectorOverlay.xul.
Bug 1322414 basically changed this to type="content" primary="true".

This needs to be ported to the current DOMi for SeaMonkey 2.50+ and any gecko 53+ application.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1324899-DOMiContentPrimary.patch

Changing content-primary and adjusting min version numbers. Setting version to 2.0.18.0 so that it updates when bundled with SeaMonkey. 

Not taking the bug yet. I am unhappy with the patch because this would make it incompatible with older versions and PM. Maybe type and primary can be set depending on version number?

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1324899-DOMiContentPrimary-V2.patch

This does it for me and preserves compatibility. 

Tested with SeaMonkey 2.50a1 and 2.49a2.

Comment 3

[Frank-Rainer Grahl (:frg)]

Ian,

can you put up a new version on AMO? Instead of 2.0.18.0 I am thinking of 2.0.17.0. Rationale for the last minor version is the same as for debugQA. If it changes it will autoupdate when bundled with a Nightly Seamonkey.

Comment 4

[Rainer Bielefeld]

(In reply to Frank-Rainer Grahl from comment #3)
Also see "Bug 1324196 - DOM Inspector 2.0.16.1-signed only compatible until SeaMonkey 2.39"

Comment 5

[Ian Neal]

(In reply to Frank-Rainer Grahl from comment #3)
> Ian,
> 
> can you put up a new version on AMO? Instead of 2.0.18.0 I am thinking of
> 2.0.17.0. Rationale for the last minor version is the same as for debugQA.
> If it changes it will autoupdate when bundled with a Nightly Seamonkey.

That would be mcsmurf, ewong, callek or KaiRo I think.

Comment 6

[Philip Chee]

Comment on attachment 8820736 [details] [diff] [review]
1324899-DOMiContentPrimary-V2.patch

> +  if (Services.vc.compare(Services.appinfo.platformVersion, "53.0a1") < 0) {
> +    let ifBrowser = document.getElementById("ifBrowser");
> +    ifBrowser.removeAttribute("primary");
> +    ifBrowser.setAttribute("type", "content-primary");

No need to remove "primary" attribute since it means nothing for Gecko < 53
Hence we can simplify:
document.getElementById("ifBrowser").setAttribute("type", "content-primary");

For uploading to AMO please ask mcsmurf.

Comment 7

[Frank-Rainer Grahl (:frg)]

Attachment: 1324899-DOMiContentPrimary-V3.patch

Fixed Patch. Tested with 2.48 and 2.50a1.

Current DOMi on AMO is 2.0.16.1 so I put 2.0.17.0 in the patch. 

Review+ from Philip Chee carried forward.

Comment 8

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/dom-inspector/rev/a69769cacd8dbf7b2d41ff361c25d3712c72355d

If you installed the 2.0.18.0 xpi from the previous patch please install the 2.0.17.0 xpi manually again.

Comment 9

[Frank-Rainer Grahl (:frg)]

Callek,

die you find the AMO password and could you give it to a council member?

Comment 10

[Justin Wood (:Callek)]

(In reply to Frank-Rainer Grahl from comment #9)
> Callek,
> 
> die you find the AMO password and could you give it to a council member?

I did not find it yet, will leave the n-i open so I can try and squeeze looking into my agenda this week.