1324904 - convert nsISupportsArray in mozilla/extensions/irc

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[:aceman]

mozilla/extensions/irc/xul/content/nsClipboard.js
* nsISupportsArray getClipboardTransferable (Object aFlavourList) ;
* returns a nsISupportsArray of the item on the clipboard
const supportsIID = Components.interfaces.nsISupportsArray;

mozilla/extensions/irc/xul/content/nsDragAndDrop.js
*        a reference to a function that returns a nsISupportsArray of nsITransferables

Comment 1

[:aceman]

Attachment: patch

Comment 2

[:Gijs (he/him)]

Comment on attachment 8820412 [details] [diff] [review]
patch

Review of attachment 8820412 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!

Comment 3

[James Ross]

Is the patch compatible with the last ESR or two?

Comment 4

[:Gijs (he/him)]

(In reply to James Ross from comment #3)
> Is the patch compatible with the last ESR or two?

Yes, nsIMutableArray has existed ~forever, and AFAICT all this code is CZ-internal at this point anyway. getClipboardTransferable only gets called from nsDragAndDrop's nsTransferable.get, which gets called from nsClipboard.js's own "read" method. nsTransferable.get converts everything from an nsI<Whatever>Array to a JS array anyway, so for consumers further down nothing changes.

Comment 5

[:aceman]

Thanks.

Comment 6

[Iris Hsiao [:ihsiao]]

Please rebase the trunk.
unable to find 'xul/content/nsClipboard.js' for patching
1 out of 1 hunks FAILED -- saving rejects to file xul/content/nsClipboard.js.rej
unable to find 'xul/content/nsDragAndDrop.js' for patching
1 out of 1 hunks FAILED -- saving rejects to file xul/content/nsDragAndDrop.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 1324904.patch

Comment 7

[:Gijs (he/him)]

(In reply to Iris Hsiao [:ihsiao] from comment #6)
> Please rebase the trunk.
> unable to find 'xul/content/nsClipboard.js' for patching
> 1 out of 1 hunks FAILED -- saving rejects to file
> xul/content/nsClipboard.js.rej
> unable to find 'xul/content/nsDragAndDrop.js' for patching
> 1 out of 1 hunks FAILED -- saving rejects to file
> xul/content/nsDragAndDrop.js.rej
> patch failed, unable to continue (try -v)
> patch failed, rejects left in working directory
> errors during apply, please fix and qrefresh 1324904.patch

WFM using `hg import bz://1324904` ? How are you importing?

remote:   https://hg.mozilla.org/chatzilla/rev/b7a99fda77ea3b78708b5bc635a41f6e3ab19b5c