1324905 - convert nsISupportsArray in mozilla/extensions/inspector

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[:aceman]

mozilla/extensions/inspector/resources/content/jsutil/xul/DNDUtils.js
var transArray = XPCU.createInstance("@mozilla.org/supports-array;1", "nsISupportsArray");

Comment 1

[:aceman]

Attachment: patch

Comment 2

[:aceman]

nsIDragService.invokeDragSession takes a nsIArray:
https://dxr.mozilla.org/comm-central/rev/d4b3146a5567a7ddbcdfa5244945db55616cb8d1/mozilla/widget/nsIDragService.idl#53

Unless this inspector code calls some other implementation.

Comment 3

[Philip Chee]

Comment on attachment 8820416 [details] [diff] [review]
patch

r=me

Comment 4

[:aceman]

Thanks.

Comment 5

[Iris Hsiao [:ihsiao]]

Please rebase the trunk.
unable to find 'resources/content/jsutil/xul/DNDUtils.js' for patching
1 out of 1 hunks FAILED -- saving rejects to file resources/content/jsutil/xul/DNDUtils.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 1324905.patch

Comment 6

[:aceman]

I think these files are in a different repo (not normal m-c). Gijs, can you please check in this one too?

Comment 7

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/dom-inspector/rev/2fdd48d9482c78d0a7cd79322fc0de719e07653b


Dunno if this needs anything else to be marked FIXED?

Comment 8

[:aceman]

Thanks, I think it landed correctly. The occurrence of nsISupportsArray vanished from DXR listing where I found it.