Closed Bug 1324905 Opened 5 years ago Closed 4 years ago

convert nsISupportsArray in mozilla/extensions/inspector

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla53

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file)

1.60 KB, patch
philip.chee
: review+
Details | Diff | Splinter Review
mozilla/extensions/inspector/resources/content/jsutil/xul/DNDUtils.js
var transArray = XPCU.createInstance("@mozilla.org/supports-array;1", "nsISupportsArray");
Attached patch patchSplinter Review
Attachment #8820416 - Flags: review?(philip.chee)
nsIDragService.invokeDragSession takes a nsIArray:
https://dxr.mozilla.org/comm-central/rev/d4b3146a5567a7ddbcdfa5244945db55616cb8d1/mozilla/widget/nsIDragService.idl#53

Unless this inspector code calls some other implementation.
Comment on attachment 8820416 [details] [diff] [review]
patch

r=me
Attachment #8820416 - Flags: review?(philip.chee) → review+
Thanks.
Keywords: checkin-needed
Please rebase the trunk.
unable to find 'resources/content/jsutil/xul/DNDUtils.js' for patching
1 out of 1 hunks FAILED -- saving rejects to file resources/content/jsutil/xul/DNDUtils.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 1324905.patch
Flags: needinfo?(acelists)
Keywords: checkin-needed
I think these files are in a different repo (not normal m-c). Gijs, can you please check in this one too?
Flags: needinfo?(acelists) → needinfo?(gijskruitbosch+bugs)
remote:   https://hg.mozilla.org/dom-inspector/rev/2fdd48d9482c78d0a7cd79322fc0de719e07653b


Dunno if this needs anything else to be marked FIXED?
Flags: needinfo?(gijskruitbosch+bugs)
Thanks, I think it landed correctly. The occurrence of nsISupportsArray vanished from DXR listing where I found it.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.