e10s - View source can fail for file:/// urls opened in new tabs from other file:/// urls because we pick the wrong remote tab type

RESOLVED DUPLICATE of bug 1321020

Status

()

Toolkit
View Source
RESOLVED DUPLICATE of bug 1321020
a year ago
a year ago

People

(Reporter: jgilbert, Unassigned)

Tracking

({regression})

unspecified
regression
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox52 unaffected, firefox53 fixed)

Details

(Whiteboard: [workaround in comment 14)

Attachments

(1 attachment)

Comment hidden (empty)
Works for me with 50.1.0 with e10s disabled. Is this a regression?
(Reporter)

Comment 2

a year ago
I see this on Nightly 53 on both Windows and Mac.
status-firefox50: --- → unaffected
status-firefox53: --- → affected
(Reporter)

Updated

a year ago
Keywords: regressionwindow-wanted
:Gijs, is this related to view-source security changes, such as bug 1290668?
Flags: needinfo?(gijskruitbosch+bugs)

Comment 4

a year ago
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> :Gijs, is this related to view-source security changes, such as bug 1290668?

I don't think so, if it works on 52.

I can't reproduce on OSX. It doesn't help that there are no steps to reproduce in the bug as filed. Here's what I did:


1. open nightly
2. open file:///.../testcases/some-file.htm?foo=bar
3. hit cmd-u

and that worked, with e10s turned on and with e10s turned off.

What OS is this reproducing on? What am I missing about the STR? Does it break in a clean profile on Nightly?

It's potentially possible this is related to the file: process separation and sandboxing but then I'd expect non-query-param'd URIs to break too, and I'd expect us to have noticed sooner. CC'ing Bob anyway in case he has ideas (x-ref bug 1147911).
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(jgilbert)

Comment 5

a year ago
(I see comment #2 mentions Windows and Mac. In case it matters, I'm on macOs Sierra. Tested with yesterday's nightly as today's isn't out yet.)
I can't reproduce either on Windows 10 with e10s on and off. I also copy and pasted a view-source URL into the location bar.
Status: NEW → UNCONFIRMED
Ever confirmed: false
Keywords: steps-wanted
Works for me too on Windows 7 (Nightly from a couple of days ago).

However, there is certainly a possibility that bug 1147911 could have caused issues here, but we need more detail to reproduce.
(Reporter)

Comment 8

a year ago
It seems to be working on today's Nightly. It was definitely not working yesterday on either machine.

* Load some file:///foo.html?bar=true
* Try to view source
* Get blank page

I think I've had this problem off-and-on for a few weeks now. I'll keep an eye out for it happening again.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(jgilbert)
Keywords: steps-wanted
(Reporter)

Updated

a year ago
Summary: View source fails for file:/// urls with search args (.../foo.html?bar=false) → View source can fail for file:/// urls with search args (.../foo.html?bar=false)
(Reporter)

Comment 9

a year ago
Ok, poke around after hitting this again.

I have a file:/// page that has links to tests. If I click on the link, it automatically opens a new tab. This new tab gives a blank page when I try to view source.

If I right-click on the link and choose 'open in new tab', view source works normally.
(Reporter)

Comment 10

a year ago
If I load it from a localhost webserver instead, view source works correctly.
(Reporter)

Comment 11

a year ago
Created attachment 8820910 [details]
testcase
(Reporter)

Updated

a year ago
Flags: needinfo?(gijskruitbosch+bugs)
Reproduced it with an e10s window, but did not with a non-e10s window.

Comment 13

a year ago
Error: View source browser's remoteness mismatch  ViewSourceBrowser.jsm:234:13
	updateBrowserRemoteness resource://gre/modules/ViewSourceBrowser.jsm:234:13
	loadViewSource resource://gre/modules/ViewSourceBrowser.jsm:193:7
	viewSourceInBrowser chrome://global/content/viewSourceUtils.js:99:5
	viewInternal chrome://browser/content/browser.js:2298:7
	BrowserViewSourceOfDocument chrome://browser/content/browser.js:2315:5
	BrowserViewSource chrome://browser/content/browser.js:2328:3
	oncommand chrome://browser/content/browser.xul:1:1


Looking at this code a bit, I think the patches in bug 1321020 should fix this. Bob, can you confirm?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(bobowencode)

Updated

a year ago
Summary: View source can fail for file:/// urls with search args (.../foo.html?bar=false) → e10s - View source can fail for file:/// urls opened in new tabs from other file:/// urls because we pick the wrong remote tab type

Comment 14

a year ago
Turning off browser.tabs.remote.separateFileUriProcess is a workaround if this is causing problems in day-to-day operation.
Blocks: 1147911
Keywords: regressionwindow-wanted → regression
Whiteboard: [workaround in comment 14
(In reply to :Gijs Kruitbosch from comment #13)

> Looking at this code a bit, I think the patches in bug 1321020 should fix
> this. Bob, can you confirm?

Yes, looks like this is a special case of bug 1321020, should get that landed tomorrow, once I fix up the test.
Status: NEW → RESOLVED
Last Resolved: a year ago
Flags: needinfo?(bobowencode)
Resolution: --- → DUPLICATE
Duplicate of bug: 1321020
Fixed in the duplicate bug.
status-firefox52: --- → unaffected
status-firefox53: affected → fixed
You need to log in before you can comment on or make changes to this bug.