1324912 - e10s - View source can fail for file:/// urls opened in new tabs from other file:/// urls because we pick the wrong remote tab type

Status: RESOLVED DUPLICATE of bug 1321020

(Toolkit :: View Source, defect)

Comment 1

[Masatoshi Kimura [:emk]]

Works for me with 50.1.0 with e10s disabled. Is this a regression?

Comment 2

[Kelsey Gilbert [:jgilbert]]

I see this on Nightly 53 on both Windows and Mac.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:Gijs, is this related to view-source security changes, such as bug 1290668?

Comment 4

[:Gijs (he/him)]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> :Gijs, is this related to view-source security changes, such as bug 1290668?

I don't think so, if it works on 52.

I can't reproduce on OSX. It doesn't help that there are no steps to reproduce in the bug as filed. Here's what I did:


1. open nightly
2. open file:///.../testcases/some-file.htm?foo=bar
3. hit cmd-u

and that worked, with e10s turned on and with e10s turned off.

What OS is this reproducing on? What am I missing about the STR? Does it break in a clean profile on Nightly?

It's potentially possible this is related to the file: process separation and sandboxing but then I'd expect non-query-param'd URIs to break too, and I'd expect us to have noticed sooner. CC'ing Bob anyway in case he has ideas (x-ref bug 1147911).

Comment 5

[:Gijs (he/him)]

(I see comment #2 mentions Windows and Mac. In case it matters, I'm on macOs Sierra. Tested with yesterday's nightly as today's isn't out yet.)

Comment 6

[Masatoshi Kimura [:emk]]

I can't reproduce either on Windows 10 with e10s on and off. I also copy and pasted a view-source URL into the location bar.

Comment 7

[Bob Owen (:bobowen)]

Works for me too on Windows 7 (Nightly from a couple of days ago).

However, there is certainly a possibility that bug 1147911 could have caused issues here, but we need more detail to reproduce.

Comment 8

[Kelsey Gilbert [:jgilbert]]

It seems to be working on today's Nightly. It was definitely not working yesterday on either machine.

* Load some file:///foo.html?bar=true
* Try to view source
* Get blank page

I think I've had this problem off-and-on for a few weeks now. I'll keep an eye out for it happening again.

Comment 9

[Kelsey Gilbert [:jgilbert]]

Ok, poke around after hitting this again.

I have a file:/// page that has links to tests. If I click on the link, it automatically opens a new tab. This new tab gives a blank page when I try to view source.

If I right-click on the link and choose 'open in new tab', view source works normally.

Comment 10

[Kelsey Gilbert [:jgilbert]]

If I load it from a localhost webserver instead, view source works correctly.

Comment 11

[Kelsey Gilbert [:jgilbert]]

Attachment: testcase

Comment 12

[Masatoshi Kimura [:emk]]

Reproduced it with an e10s window, but did not with a non-e10s window.

Comment 13

[:Gijs (he/him)]

Error: View source browser's remoteness mismatch  ViewSourceBrowser.jsm:234:13
	updateBrowserRemoteness resource://gre/modules/ViewSourceBrowser.jsm:234:13
	loadViewSource resource://gre/modules/ViewSourceBrowser.jsm:193:7
	viewSourceInBrowser chrome://global/content/viewSourceUtils.js:99:5
	viewInternal chrome://browser/content/browser.js:2298:7
	BrowserViewSourceOfDocument chrome://browser/content/browser.js:2315:5
	BrowserViewSource chrome://browser/content/browser.js:2328:3
	oncommand chrome://browser/content/browser.xul:1:1


Looking at this code a bit, I think the patches in bug 1321020 should fix this. Bob, can you confirm?

Comment 14

[:Gijs (he/him)]

Turning off browser.tabs.remote.separateFileUriProcess is a workaround if this is causing problems in day-to-day operation.

Comment 15

[Bob Owen (:bobowen)]

(In reply to :Gijs Kruitbosch from comment #13)

> Looking at this code a bit, I think the patches in bug 1321020 should fix
> this. Bob, can you confirm?

Yes, looks like this is a special case of bug 1321020, should get that landed tomorrow, once I fix up the test.

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Fixed in the duplicate bug.