1324914 - Remove (unpublished) pre-v8 DB migration

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Andrzej Hunt :ahunt]

AIUI the first version of Fennec using Java based DB management code was Fennec 14, which used the v8 DB schema:

https://hg.mozilla.org/releases/mozilla-release/file/35a98282d2a6/mobile/android/base/db/BrowserProvider.java.in#l70

I.e. the oldest possible database version in use by any user of release versions of Firefox will be v8 (beta/alpha/nightly testers, and developers, might have older versions).

I'd like to propose removing any code referring to and/or handling migrations from schema vX to v8 for X < 8, since no release users could possibly have older DB versions, and we shouldn't need to care about unreleased versions.

Removing support for those versions would allow us to remove the rather complicated  migrateBookmarksTable() and migratHistoryTable() methods, which would help us declutter BrowserDatabaseHelper.

Comment 1

[Andrzej Hunt :ahunt]

We could also potentially do the same for other unreleased intermediate migrations (we'd have to combine certain migrations to do that though). I've put a list of fennec relases vs db schema versions on the wiki:
https://wiki.mozilla.org/Mobile/Fennec/Android/Database_Versions

Note that care is needed in this area, it seems that some intermediate migrations have already been (erroneously) removed, see my comments at:
https://reviewboard.mozilla.org/r/98928/diff/1#index_header

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.