Remove (unpublished) pre-v8 DB migration

NEW
Unassigned

Status

()

2 years ago
2 years ago

People

(Reporter: ahunt, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox53 affected)

Details

(Reporter)

Description

2 years ago
AIUI the first version of Fennec using Java based DB management code was Fennec 14, which used the v8 DB schema:

https://hg.mozilla.org/releases/mozilla-release/file/35a98282d2a6/mobile/android/base/db/BrowserProvider.java.in#l70

I.e. the oldest possible database version in use by any user of release versions of Firefox will be v8 (beta/alpha/nightly testers, and developers, might have older versions).

I'd like to propose removing any code referring to and/or handling migrations from schema vX to v8 for X < 8, since no release users could possibly have older DB versions, and we shouldn't need to care about unreleased versions.

Removing support for those versions would allow us to remove the rather complicated  migrateBookmarksTable() and migratHistoryTable() methods, which would help us declutter BrowserDatabaseHelper.
(Reporter)

Comment 1

2 years ago
We could also potentially do the same for other unreleased intermediate migrations (we'd have to combine certain migrations to do that though). I've put a list of fennec relases vs db schema versions on the wiki:
https://wiki.mozilla.org/Mobile/Fennec/Android/Database_Versions

Note that care is needed in this area, it seems that some intermediate migrations have already been (erroneously) removed, see my comments at:
https://reviewboard.mozilla.org/r/98928/diff/1#index_header
You need to log in before you can comment on or make changes to this bug.