1325028 - Remove some more IsCallerChrome bits in nsGlobalWindow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The infrastructure in bug 1320801 lets us get rid of some of them.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove IsCallerChrome use from nsGlobalWindow's .content getter

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove IsCallerChrome use from the various things called via SetReplaceableWindowCoord

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove IsCallerChrome use from nsGlobalWindow::ResizeTo/ResizeBy/SizeToContent

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove IsCallerChrome use from nsGlobalWindow::MoveTo/MoveBy

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 5. Change nsGlonalWindow::CanMoveResizeWindows to take CallerType

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8820680 [details] [diff] [review]
part 2.  Remove IsCallerChrome use from the various things called via SetReplaceableWindowCoord

Review of attachment 8820680 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.h
@@ +1308,5 @@
>    nsresult GetInnerWidth(int32_t* aWidth) override;
> +  void SetInnerWidthOuter(int32_t aInnerWidth,
> +                          mozilla::dom::CallerType aCallerType,
> +                          mozilla::ErrorResult& aError);
> +  void SetInnerWidth(int32_t aInnerWidth, 

nit: trailing whitespace

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a97e232bbd11
part 1.  Remove IsCallerChrome use from nsGlobalWindow's .content getter.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/58fa05c29557
part 2.  Remove IsCallerChrome use from the various things called via SetReplaceableWindowCoord.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/99bb6dd6ebaa
part 3.  Remove IsCallerChrome use from nsGlobalWindow::ResizeTo/ResizeBy/SizeToContent.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/8850df6ea79d
part 4.  Remove IsCallerChrome use from nsGlobalWindow::MoveTo/MoveBy.  r=bkelly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a91c57b9a522
part 5.  Change nsGlonalWindow::CanMoveResizeWindows to take CallerType.  r=bkelly

Comment 8

[Boris Zbarsky [:bzbarsky]]

> nit: trailing whitespace

Fixed.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a97e232bbd11
https://hg.mozilla.org/mozilla-central/rev/58fa05c29557
https://hg.mozilla.org/mozilla-central/rev/99bb6dd6ebaa
https://hg.mozilla.org/mozilla-central/rev/8850df6ea79d
https://hg.mozilla.org/mozilla-central/rev/a91c57b9a522