Closed
Bug 1325090
Opened 8 years ago
Closed 8 years ago
Reduce number of HTTP_NET_VS_CACHE_ probes
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: michal, Assigned: CuveeHsu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-active])
Attachments
(1 file, 1 obsolete file)
12.40 KB,
patch
|
michal
:
review+
benjamin
:
feedback+
|
Details | Diff | Splinter Review |
Several probes give more or less the same data, e.g. all HTTP_NET_VS_CACHE_ONSTART_ SMALL,MED,LARGE,HIGHPRI,NORMALPRI. We should revise all probes and keep only those providing useful data.
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → juhsu
Whiteboard: [necko-active]
Assignee | ||
Comment 1•8 years ago
|
||
I guess we will use the DiskStorageSize in the future, so I didn't remove it. The threshold of the queue size depends on the priority, so I still leave the mCacheOpenWithPriority
Attachment #8826543 -
Flags: review?(michal.novotny)
Reporter | ||
Comment 2•8 years ago
|
||
Comment on attachment 8826543 [details] [diff] [review] reduce_probes Review of attachment 8826543 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/telemetry/Histograms.json @@ -1978,5 @@ > - "kind": "linear", > - "high": 1000, > - "n_buckets": 100, > - "description": "Network vs cache time load (OnStopRequest) difference (ms) for cache files with a large size (>256K) and high priority. Offset by 500 ms." > - }, I didn't mean to drop them all. AFAICS in the telemetry there is not a big difference between each normal/high priority pair, so we can drop this flag completely. There is also not much difference between ONSTART time for different sizes, but this is not true for ONSTOP. So we can drop all those ONSTART because they are already covered by HTTP_NET_VS_CACHE_ONSTART_NOTREVALIDATED, but we should keep ONSTOP probes for different sizes. And because there is not a big difference between small and medium size we should either merge small and medium into a single probe, or shift the size limits.
Attachment #8826543 -
Flags: review?(michal.novotny) → review-
Assignee | ||
Comment 3•8 years ago
|
||
I wasn't aware it still need to record the onStopDiff for different sizes of content. My bad.
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8826543 -
Attachment is obsolete: true
Attachment #8827782 -
Flags: review?(michal.novotny)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8827782 [details] [diff] [review] reduce_probes_v2 Review of attachment 8827782 [details] [diff] [review]: ----------------------------------------------------------------- I'm not sure if we need data review when we're removing and updating probes.
Attachment #8827782 -
Flags: review?(michal.novotny)
Attachment #8827782 -
Flags: review+
Attachment #8827782 -
Flags: feedback?(benjamin)
Comment 6•8 years ago
|
||
Comment on attachment 8827782 [details] [diff] [review] reduce_probes_v2 removing no. Updating it's good to check. This is fine.
Attachment #8827782 -
Flags: feedback?(benjamin) → feedback+
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #6) > Comment on attachment 8827782 [details] [diff] [review] > reduce_probes_v2 > > removing no. Updating it's good to check. This is fine. Actually we merged some, but it doesn't matter a lot.
Assignee | ||
Comment 8•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c322f9fe2237c999cb945b23b56978342a9758ed
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/586d65b40b24 Drop and merge HTTP_NET_VS_CACHE_* probes, r=michal
Keywords: checkin-needed
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/586d65b40b24
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•