perma? leak in toolkit/modules/tests/browser on linux debug e10s

RESOLVED FIXED in Firefox 52

Status

WebExtensions
Request Handling
RESOLVED FIXED
2 years ago
5 days ago

People

(Reporter: jmaher, Assigned: kmag)

Tracking

unspecified
mozilla53

Firefox Tracking Flags

(firefox51 unaffected, firefox52- fixed, firefox53 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
we haven't been reporting leaks as failures in treeherder, but they still exist.  Here is one that I see on linux32 and linux64 in e10s debug jobs for the toolkit/modules/tests/browser directory.  We see a leak on shutdown as seen in this log file:
https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-linux-debug/1482335873/mozilla-central_ubuntu32_vm-debug_test-mochitest-e10s-browser-chrome-4-bm03-tests1-linux32-build3.txt.gz

and some data from the log file related to the leak:
09:36:06     INFO - WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME.  FIX THIS!
09:36:06     INFO - [Parent 24145] WARNING: '!compMgr', file /builds/slave/m-cen-lx-d-0000000000000000000/build/src/xpcom/glue/nsComponentManagerUtils.cpp, line 63
09:36:06     INFO - Leaked URLs:
09:36:06     INFO -   chrome://browser/content/report-phishing-overlay.xul
09:36:06     INFO -   resource://gre-resources/counterstyles.css
09:36:06     INFO -   resource://gre-resources/html.css
09:36:06     INFO -   chrome://global/content/minimal-xul.css
09:36:06     INFO -   resource://gre-resources/quirk.css
09:36:06     INFO -   resource://gre/res/svg.css
09:36:06     INFO -   chrome://global/content/xul.css
09:36:06     INFO -   chrome://global/skin/scrollbars.css
09:36:06     INFO -   resource://gre-resources/number-control.css
09:36:06     INFO -   resource://gre-resources/forms.css
09:36:06     INFO -   resource://gre-resources/noscript.css
09:36:06     INFO -   resource://gre-resources/ua.css
09:36:06     INFO -   chrome://pluginproblem/content/pluginProblemBinding.css
09:36:06     INFO -   chrome://browser/content/browser.xul
09:36:06     INFO -   chrome://global/content/printUtils.js
09:36:06     INFO -   chrome://global/content/viewZoomOverlay.js
09:36:06     INFO -   chrome://browser/content/places/browserPlacesViews.js
09:36:06     INFO -   chrome://browser/content/browser.js
09:36:06     INFO -   chrome://browser/content/customizableui/panelUI.js
09:36:06     INFO -   chrome://global/content/viewSourceUtils.js
09:36:06     INFO -   chrome://browser/content/browser-addons.js
09:36:07     INFO -   chrome://browser/content/browser-ctrlTab.js
09:36:07     INFO -   chrome://browser/content/browser-customization.js
09:36:07     INFO -   chrome://browser/content/browser-devedition.js
09:36:07     INFO -   chrome://browser/content/browser-feeds.js
09:36:07     INFO -   chrome://browser/content/browser-fullScreenAndPointerLock.js
09:36:07     INFO -   chrome://browser/content/browser-fullZoom.js
09:36:07     INFO -   chrome://browser/content/browser-gestureSupport.js
09:36:07     INFO -   chrome://browser/content/browser-media.js
09:36:07     INFO -   chrome://browser/content/browser-places.js
09:36:07     INFO -   chrome://browser/content/browser-plugins.js
09:36:07     INFO -   chrome://browser/content/browser-refreshblocker.js
09:36:07     INFO -   chrome://browser/content/browser-safebrowsing.js
09:36:07     INFO -   chrome://browser/content/browser-sidebar.js
09:36:07     INFO -   chrome://browser/content/browser-social.js
09:36:07     INFO -   chrome://browser/content/browser-syncui.js
09:36:07     INFO -   chrome://browser/content/browser-tabsintitlebar.js
09:36:07     INFO -   chrome://browser/content/browser-thumbnails.js
09:36:07     INFO -   chrome://browser/content/browser-trackingprotection.js
09:36:07     INFO -   chrome://browser/content/browser-data-submission-info-bar.js
09:36:07     INFO -   chrome://browser/content/browser-fxaccounts.js
09:36:07     INFO -   chrome://browser/content/nsContextMenu.js
09:36:07     INFO -   chrome://global/content/contentAreaUtils.js
09:36:07     INFO -   chrome://browser/content/downloads/downloads.js
09:36:07     INFO -   chrome://browser/content/downloads/indicator.js
09:36:07     INFO -   chrome://browser/content/places/editBookmarkOverlay.js
09:36:07     INFO -   chrome://global/content/editMenuOverlay.xul
09:36:07     INFO -   chrome://browser/content/baseMenuOverlay.xul
09:36:07     INFO -   chrome://browser/content/places/placesOverlay.xul
09:36:07     INFO -   chrome://global/content/bindings/scrollbar.xml#scrollbar
09:36:07     INFO -   chrome://global/skin/scrollbar/slider.gif
09:36:07     INFO -   chrome://global/content/bindings/scrollbar.xml#thumb
09:36:07     INFO -   chrome://global/content/bindings/scrollbar.xml#scrollbar-base
09:36:07     INFO -   chrome://global/content/editMenuOverlay.js
09:36:07     INFO -   chrome://browser/content/utilityOverlay.js
09:36:07     INFO -   chrome://global/content/globalOverlay.js
09:36:07     INFO -   chrome://browser/content/places/controller.js
09:36:07     INFO -   chrome://browser/content/places/treeView.js
09:36:07     INFO -   chrome://global/content/bindings/general.xml#root-element
09:36:07     INFO -   chrome://global/content/bindings/popup.xml#tooltip
09:36:07     INFO -   chrome://global/content/bindings/stringbundle.xml#stringbundleset
09:36:07     INFO -   chrome://global/content/bindings/general.xml#deck
09:36:07     INFO -   chrome://global/content/bindings/stringbundle.xml#stringbundle
09:36:07     INFO -   chrome://global/content/bindings/popup.xml#popup
09:36:07     INFO -   chrome://global/content/bindings/autocomplete.xml#autocomplete-rich-result-popup
09:36:07     INFO -   chrome://global/content/bindings/menulist.xml#menulist-popuponly
09:36:07     INFO -   chrome://global/content/bindings/popup.xml#arrowpanel
09:36:07     INFO -   chrome://global/content/bindings/popup.xml#panel
09:36:07     INFO -   chrome://global/content/bindings/notification.xml#popup-notification
09:36:07     INFO -   chrome://global/content/bindings/general.xml#image
09:36:07     INFO -   chrome://global/content/bindings/toolbar.xml#toolbox
09:36:07     INFO -   chrome://global/content/bindings/toolbar.xml#menubar
09:36:07     INFO -   chrome://global/content/bindings/menu.xml#menu-menubar
09:36:07     INFO -   chrome://global/content/bindings/text.xml#text-label
09:36:07     INFO -   chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton
09:36:07     INFO -   chrome://global/content/bindings/toolbarbutton.xml#menu
09:36:07     INFO -   chrome://global/content/bindings/scrollbox.xml#scrollbox
09:36:07     INFO -   chrome://global/content/bindings/text.xml#label-control
09:36:07     INFO -   chrome://global/content/bindings/general.xml#dropmarker
09:36:07     INFO -   chrome://global/content/bindings/toolbarbutton.xml#menu-button
09:36:07     INFO -   chrome://global/content/bindings/textbox.xml#input-box
09:36:07     INFO -   chrome://global/content/bindings/autocomplete.xml#history-dropmarker
09:36:07     INFO -   chrome://global/content/platformHTMLBindings.xml#inputFields
09:36:07     INFO -   chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton-badged
09:36:07     INFO -   chrome://global/content/bindings/splitter.xml#splitter
09:36:07     INFO -   chrome://global/content/bindings/notification.xml#notificationbox
09:36:07     INFO -   chrome://global/content/bindings/tabbox.xml#tabpanels
09:36:07     INFO -   chrome://global/content/bindings/menu.xml#menuitem
09:36:07     INFO -   chrome://global/content/bindings/menu.xml#menuseparator
09:36:07     INFO -   chrome://global/content/bindings/menu.xml#menu-iconic
09:36:07     INFO -   chrome://global/content/bindings/toolbar.xml#toolbardecoration
09:36:07     INFO -   chrome://global/content/bindings/browser.xml#browser
09:36:07     INFO -   chrome://global/content/bindings/menu.xml#menu
09:36:07     INFO -   chrome://global/content/bindings/text.xml#text-base
09:36:07     INFO -   chrome://mochikit/content/browser-test-overlay.xul
09:36:07     INFO -   chrome://mochikit/content/chrome-harness.js
09:36:07     INFO -   chrome://mochikit/content/mochitest-e10s-utils.js
09:36:07     INFO -   chrome://mochikit/content/browser-test.js
09:36:07     INFO -   chrome://mochikit/content/browser-harness.xul
09:36:07     INFO -   chrome://mochikit/content/tests/SimpleTest/MozillaLogger.js
09:36:07     INFO -   chrome://mochikit/content/tests/SimpleTest/LogController.js
09:36:07     INFO -   chrome://mochikit/content/tests/SimpleTest/StructuredLog.jsm
09:36:07     INFO -   chrome://mochikit/content/tests/SimpleTest/TestRunner.js
09:36:07     INFO -   chrome://mochikit/content/manifestLibrary.js
09:36:07     INFO -   chrome://mochikit/content/chunkifyTests.js
09:36:07     INFO -   chrome://global/content/bindings/button.xml#button
09:36:07     INFO -   http://127.0.0.1:8888/dummy-gmp-manager.xml
09:36:07     INFO -   http://127.0.0.1:8888/dummy-gmp-manager.xml
09:36:07     INFO - [Parent 24145] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/slave/m-cen-lx-d-0000000000000000000/build/src/xpcom/base/nsTraceRefcnt.cpp, line 172
09:36:07     INFO - [Parent 24145] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/slave/m-cen-lx-d-0000000000000000000/build/src/xpcom/base/nsTraceRefcnt.cpp, line 172
09:36:07     INFO - [Parent 24145] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/slave/m-cen-lx-d-0000000000000000000/build/src/xpcom/base/nsTraceRefcnt.cpp, line 172
09:36:07     INFO - [Parent 24145] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/slave/m-cen-lx-d-0000000000000000000/build/src/xpcom/base/nsTraceRefcnt.cpp, line 172
09:36:07     INFO - nsStringStats
09:36:07     INFO -  => mAllocCount:         234664
09:36:07     INFO -  => mReallocCount:        21466
09:36:07     INFO -  => mFreeCount:          232126  --  LEAKED 2538 !!!
09:36:07     INFO -  => mShareCount:         176498
09:36:07     INFO -  => mAdoptCount:          15634
09:36:07     INFO -  => mAdoptFreeCount:      15632  --  LEAKED 2 !!!
09:36:07     INFO -  => Process ID: 24145, Thread ID: 3074602752
09:36:07     INFO - TEST-INFO | Main app process: exit 0
09:36:07     INFO - runtests.py | Application ran for: 0:01:59.386237
09:36:07     INFO - zombiecheck | Reading PID log: /tmp/tmpn7LJmupidlog
09:36:07     INFO - ==> process 24145 launched child process 24165
09:36:07     INFO - ==> process 24145 launched child process 24197
09:36:07     INFO - zombiecheck | Checking for orphan process with PID: 24165
09:36:07     INFO - zombiecheck | Checking for orphan process with PID: 24197
09:36:07     INFO - Stopping web server
09:36:07     INFO - Stopping web socket server
09:36:07     INFO - Stopping ssltunnel
09:36:07     INFO - TEST-INFO | leakcheck | default process: leak threshold set at 0 bytes
09:36:07     INFO - TEST-INFO | leakcheck | plugin process: leak threshold set at 0 bytes
09:36:07     INFO - TEST-INFO | leakcheck | tab process: leak threshold set at 10000 bytes
09:36:07     INFO - TEST-INFO | leakcheck | geckomediaplugin process: leak threshold set at 20000 bytes
09:36:07     INFO - TEST-INFO | leakcheck | gpu process: leak threshold set at 0 bytes
09:36:07     INFO - 
09:36:07     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, tab process 24197
09:36:07     INFO - 
09:36:07     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
09:36:07     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
09:36:07     INFO -    0 |TOTAL                                 |       22        0|  822811        0|
09:36:07     INFO - 
09:36:07     INFO - nsTraceRefcnt::DumpStatistics: 833 entries
09:36:07     INFO - 
09:36:07     INFO - TEST-PASS | leakcheck | tab process: no leaks detected!
09:36:07     INFO - 
09:36:07     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, default process 24145
09:36:07     INFO - 
09:36:07     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
09:36:07     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
09:36:07     INFO -    0 |TOTAL                                 |       18   367239| 6414120    15833|
09:36:07     INFO -   25 |AsyncLatencyLogger                    |       44       44|       1        1|
09:36:07     INFO -   36 |BackstagePass                         |       52      208|     346        4|
09:36:07     INFO -   60 |CSSStyleSheet                         |       96     1440|      85       15|
09:36:07     INFO -   61 |CSSStyleSheetInner                    |      116     1508|      65       13|
09:36:07     INFO -   81 |CacheObserver                         |       24       24|       1        1|
09:36:07     INFO -   89 |CallbackObject                        |       28      112|    5714        4|
09:36:07     INFO -  126 |CondVar                               |       24      312|     506       13|
09:36:07     INFO -  142 |ConsoleReportCollector                |       36      144|     330        4|
09:36:07     INFO -  148 |CopyOnWriteValue                      |       24       24|      76        1|
09:36:07     INFO -  160 |DOMEventTargetHelper                  |       40       40|     248        1|
09:36:07     INFO -  170 |DOMStorageObserver                    |       28       28|       1        1|
09:36:07     INFO -  173 |DR_State                              |       32       32|       1        1|
09:36:07     INFO -  186 |DataStorage                           |      220      660|       3        3|
09:36:07     INFO -  198 |Declaration                           |       96    56928|    3555      593|
09:36:07     INFO -  215 |DocumentRule                          |       44       44|       1        1|
09:36:07     INFO -  230 |EventListenerManager                  |       92       92|    1267        1|
09:36:07     INFO -  235 |ExpirationTrackerObserver             |       16       48|      85        3|
09:36:07     INFO -  241 |FallbackEncoding                      |       12       12|       1        1|
09:36:07     INFO -  249 |FontFamilyListRefCnt                  |       16      112|      11        7|
09:36:07     INFO -  252 |FragmentOrElement                     |       60      420|    8858        7|
09:36:07     INFO -  269 |GenericFactory                        |       16       32|     270        2|
09:36:07     INFO -  278 |GroupRule                             |       36      396|      68       11|
09:36:07     INFO -  311 |HttpBaseChannel                       |      940      940|     173        1|
09:36:07     INFO -  333 |IdlePeriod                            |       12       60|      53        5|
09:36:07     INFO -  339 |ImageLoader                           |      132      132|      76        1|
09:36:07     INFO -  343 |ImageURL                              |      260      520|     155        2|
09:36:07     INFO -  369 |LiteralImpl                           |       12       12|      82        1|
09:36:07     INFO -  372 |LoadInfo                              |      140      140|    2563        1|
09:36:07     INFO -  374 |Loader                                |      116      232|      81        2|
09:36:07     INFO -  379 |MaskLayerImageCache                   |       36       36|       1        1|
09:36:07     INFO -  385 |MediaRule                             |       44      440|      47       10|
09:36:07     INFO -  399 |Mutex                                 |       20      540|    2298       27|
09:36:07     INFO -  401 |NameSpaceRule                         |       48      912|      51       19|
09:36:07     INFO -  405 |NodeInfo                              |       76      684|    1391        9|
09:36:07     INFO -  413 |ObserverTable                         |       44       44|      76        1|
09:36:07     INFO -  494 |PollableEvent                         |       12       12|       1        1|
09:36:07     INFO -  515 |ProgressTracker                       |       52       52|      76        1|
09:36:07     INFO -  517 |ProtoAndIfaceCache                    |        8       56|     395        7|
09:36:07     INFO -  531 |RDFServiceImpl                        |      224      224|       1        1|
09:36:07     INFO -  534 |RasterImage                           |      200      200|      27        1|
09:36:07     INFO -  536 |ReentrantMonitor                      |       24       96|    1167        4|
09:36:07     INFO -  543 |RequestContextService                 |       56       56|       1        1|
09:36:07     INFO -  551 |RuleHash                              |      164    16564|     196      101|
09:36:07     INFO -  552 |RuleProcessorCache                    |       60       60|       1        1|
09:36:07     INFO -  553 |Runnable                              |       20       20|   49869        1|
09:36:07     INFO -  556 |SVGAttrAnimationRuleProcessor         |       12       12|      67        1|
09:36:07     INFO -  569 |SandboxPrivate                        |       52      156|      25        3|
09:36:07     INFO -  578 |Service                               |       80       80|       1        1|
09:36:07     INFO -  607 |StringAdopt                           |        1        2|   15634        2|
09:36:07     INFO -  608 |StyleRule                             |       40    23720|    3179      593|
09:36:07     INFO -  609 |StyleSheet                            |       52      780|      85       15|
09:36:07     INFO -  633 |ThirdPartyUtil                        |       16       16|       1        1|
09:36:07     INFO -  652 |URIPrincipalReferrerPolicyAndCORSModeH|       20      160|     128        8|
09:36:07     INFO -  655 |URLValueData                          |       32     6336|     740      198|
09:36:07     INFO -  658 |UploadLastDir                         |       20       20|       1        1|
09:36:07     INFO -  677 |WatchdogManager                       |       56       56|       1        1|
09:36:07     INFO -  680 |WeakReference<IProgressObserver>      |       16       16|     777        1|
09:36:07     INFO -  681 |WeakReference<ImageContainer>         |       16       16|     133        1|
09:36:07     INFO -  682 |WeakReference<ProgressTracker>        |       16       16|      76        1|
09:36:07     INFO -  684 |WeakReference<RasterImage>            |       16       16|      27        1|
09:36:07     INFO -  687 |WeakReference<nsDocShell>             |       16       16|     261        1|
09:36:07     INFO -  720 |XMLDocument                           |     1400     1400|      51        1|
09:36:07     INFO -  721 |XMLHttpRequestEventTarget             |       44       44|     108        1|
09:36:07     INFO -  722 |XMLHttpRequestMainThread              |      384      384|      52        1|
09:36:07     INFO -  723 |XMLHttpRequestStringBuffer            |       40       40|     212        1|
09:36:07     INFO -  727 |XPCLocaleCallbacks                    |       28       28|       1        1|
09:36:07     INFO -  728 |XPCNativeInterface                    |       28       56|    2811        2|
09:36:07     INFO -  729 |XPCNativeMember                       |        8       16|   65154        2|
09:36:07     INFO -  730 |XPCNativeScriptableInfo               |        4       16|    4411        4|
09:36:07     INFO -  731 |XPCNativeSet                          |       16       32|    1768        2|
09:36:07     INFO -  733 |XPCWrappedNative                      |       48      240|   26928        5|
09:36:07     INFO -  734 |XPCWrappedNativeProto                 |       20       80|    6416        4|
09:36:07     INFO -  735 |XPCWrappedNativeScope                 |       72      504|     389        7|
09:36:07     INFO -  737 |XPCWrappedNativeTearOff               |       16       80|   34801        5|
09:36:07     INFO -  763 |image::SourceBuffer                   |       48       48|      27        1|
09:36:07     INFO -  764 |imgCacheEntry                         |       40       40|      76        1|
09:36:07     INFO -  768 |imgRequest                            |      236      236|      76        1|
09:36:07     INFO -  769 |imgRequestProxy                       |       68       68|     259        1|
09:36:07     INFO -  819 |nsAtomList                            |        8     1296|    4890      162|
09:36:07     INFO -  821 |nsAttrSelector                        |       32    12032|    2141      376|
09:36:07     INFO -  822 |nsAuthURLParser                       |       12       24|       2        2|
09:36:07     INFO -  824 |nsAutoCopyListener                    |       16       16|       1        1|
09:36:07     INFO -  833 |nsBasicDecoderSupport                 |       20       20|     390        1|
09:36:07     INFO -  835 |nsBidiKeyboard                        |       16       16|       1        1|
09:36:07     INFO -  838 |nsBindingManager                      |       48       48|      76        1|
09:36:07     INFO -  840 |nsBoxLayout                           |       12       24|       2        2|
09:36:07     INFO -  849 |nsCSSCounterStyleRule                 |      128     8832|      69       69|
09:36:07     INFO -  852 |nsCSSRect                             |       32     2976|    8658       93|
09:36:07     INFO -  853 |nsCSSRect_heap                        |       40     3720|    4078       93|
09:36:07     INFO -  854 |nsCSSRuleProcessor                    |       60      360|      75        6|
09:36:07     INFO -  856 |nsCSSSelector                         |       40    73200|    8135     1830|
09:36:07     INFO -  857 |nsCSSSelectorList                     |       12    15528|    5173     1294|
09:36:07     INFO -  860 |nsCSSValue::Array                     |       16      784|    4823       49|
09:36:07     INFO -  862 |nsCSSValueGradient                    |       56      280|     971        5|
09:36:07     INFO -  863 |nsCSSValueGradientStop                |       20      440|    3780       22|
09:36:07     INFO -  864 |nsCSSValueList                        |       12    10404|    4139      867|
09:36:07     INFO -  865 |nsCSSValueList_heap                   |       20     5040|    3134      252|
09:36:07     INFO -  866 |nsCSSValuePair                        |       16     1104|    4732       69|
09:36:07     INFO -  867 |nsCSSValuePairList                    |       20     4240|     674      212|
09:36:07     INFO -  868 |nsCSSValuePairList_heap               |       28     1316|     365       47|
09:36:07     INFO -  869 |nsCSSValuePair_heap                   |       24     1536|    1335       64|
09:36:07     INFO -  870 |nsCSSValueSharedList                  |        8       16|      73        2|
09:36:07     INFO -  872 |nsCSSValueTriplet                     |       24       24|       5        1|
09:36:07     INFO -  873 |nsCSSValueTriplet_heap                |       32       32|       3        1|
09:36:07     INFO -  879 |nsCategoryObserver                    |       64      192|       8        3|
09:36:07     INFO -  900 |nsConsoleService                      |       96       96|       1        1|
09:36:07     INFO -  905 |nsContentPolicy                       |       44       44|       1        1|
09:36:07     INFO -  913 |nsCookiePermission                    |       36       36|       1        1|
09:36:07     INFO -  914 |nsCookieService                       |       80       80|       1        1|
09:36:07     INFO -  921 |nsDNSService                          |      104      104|       1        1|
09:36:07     INFO -  924 |nsDOMClassInfo                        |       20      580|      29       29|
09:36:07     INFO -  935 |nsDateTimeFormatUnix                  |       68       68|       1        1|
09:36:07     INFO -  972 |nsDocument                            |     1384     1384|      76        1|
09:36:07     INFO -  978 |nsEffectiveTLDService                 |       20       20|       1        1|
09:36:07     INFO -  982 |nsEventListenerThisTranslator         |       12       12|       1        1|
09:36:07     INFO -  999 |nsFocusManager                        |       56       56|       1        1|
09:36:07     INFO - 1015 |nsGenericDOMDataNode                  |       64      704|    6483       11|
09:36:07     INFO - 1021 |nsHTMLCSSStyleSheet                   |       48       48|      67        1|
09:36:07     INFO - 1022 |nsHTMLDNSPrefetch::nsDeferrals        |     4136     4136|       1        1|
09:36:07     INFO - 1023 |nsHTMLDNSPrefetch::nsListener         |       12       12|       1        1|
09:36:07     INFO - 1025 |nsHTMLStyleSheet                      |      108      108|      67        1|
09:36:07     INFO - 1026 |nsHTMLStyleSheet::GenericTableRule    |       12       24|     134        2|
09:36:07     INFO - 1033 |nsHtml5AttributeName                  |       16     9328|     588      583|
09:36:07     INFO - 1036 |nsHtml5ElementName                    |       16     6368|     398      398|
09:36:07     INFO - 1037 |nsHtml5HtmlAttributes                 |       32       32|      26        1|
09:36:07     INFO - 1054 |nsHttpAuthCache::OriginClearObserver  |       16       32|       2        2|
09:36:07     INFO - 1055 |nsHttpChannel                         |     1188     1188|     173        1|
09:36:07     INFO - 1058 |nsHttpConnectionInfo                  |      140      140|     122        1|
09:36:07     INFO - 1059 |nsHttpConnectionMgr                   |      196      196|       1        1|
09:36:07     INFO - 1061 |nsHttpHandler                         |      540      540|       1        1|
09:36:07     INFO - 1063 |nsHttpRequestHead                     |       92       92|     173        1|
09:36:07     INFO - 1066 |nsIDNService                          |       56       56|       1        1|
09:36:07     INFO - 1069 |nsIOService                           |      160      160|       1        1|
09:36:07     INFO - 1091 |nsJISx4051LineBreaker                 |       12       12|       1        1|
09:36:07     INFO - 1097 |nsJSPrincipals                        |       16      128|    1849        8|
09:36:07     INFO - 1099 |nsLanguageAtomService                 |       52       52|       1        1|
09:36:07     INFO - 1102 |nsLayoutStatics                       |        1        1|       1        1|
09:36:07     INFO - 1103 |nsLayoutStylesheetCache               |       96       96|       1        1|
09:36:07     INFO - 1108 |nsLocalFile                           |      124      372|    9422        3|
09:36:07     INFO - 1114 |nsMainThreadPtrHolder<T>              |       12     7692|    2914      641|
09:36:07     INFO - 1116 |nsMediaList                           |       32      320|      64       10|
09:36:07     INFO - 1138 |nsNativeTheme                         |      112      112|       1        1|
09:36:07     INFO - 1139 |nsNativeThemeGTK                      |     1176     1176|       1        1|
09:36:07     INFO - 1146 |nsNodeInfoManager                     |       44       44|      84        1|
09:36:07     INFO - 1149 |nsNotifyAddrListener                  |       96       96|       1        1|
09:36:07     INFO - 1150 |nsNullPrincipalURI                    |       80      480|     245        6|
09:36:07     INFO - 1157 |nsOnloadBlocker                       |       12       12|      76        1|
09:36:07     INFO - 1166 |nsParserService                       |       12       12|       1        1|
09:36:07     INFO - 1172 |nsPermissionManager                   |       96       96|       1        1|
09:36:07     INFO - 1173 |nsPersistentProperties                |       80       80|      25        1|
09:36:07     INFO - 1180 |nsPrefBranch                          |       80       80|      44        1|
09:36:07     INFO - 1187 |nsProperties                          |        8        8|      76        1|
09:36:07     INFO - 1189 |nsProxyInfo                           |       72       72|     150        1|
09:36:07     INFO - 1190 |nsPseudoClassList                     |       12     6492|    1358      541|
09:36:07     INFO - 1191 |nsRDFResource                         |       28       84|     337        3|
09:36:07     INFO - 1196 |nsRect                                |       16       32| 3734005        2|
09:36:07     INFO - 1198 |nsRepeatService                       |       24       24|       1        1|
09:36:07     INFO - 1218 |nsSampleWordBreaker                   |       12       12|       1        1|
09:36:07     INFO - 1227 |nsScriptLoader                        |      192      192|      76        1|
09:36:07     INFO - 1228 |nsScriptNameSpaceManager              |       60       60|       1        1|
09:36:07     INFO - 1229 |nsScriptSecurityManager               |       52       52|       1        1|
09:36:07     INFO - 1242 |nsSimpleURI                           |       84       84|    1662        1|
09:36:07     INFO - 1243 |nsSiteSecurityService                 |       48       48|       1        1|
09:36:07     INFO - 1247 |nsSocketTransportService              |      168      168|       1        1|
09:36:07     INFO - 1249 |nsStandardURL                         |      192    20736|   18908      108|
09:36:07     INFO - 1251 |nsStaticCaseInsensitiveNameTable      |       52      312|       6        6|
09:36:07     INFO - 1255 |nsStreamConverterService              |       48       48|       1        1|
09:36:07     INFO - 1257 |nsStreamListenerWrapper               |       20       40|     107        2|
09:36:07     INFO - 1260 |nsStringBuffer                        |        8    20336|  256130     2542|
09:36:07     INFO - 1261 |nsStringBundle                        |       60       60|      31        1|
09:36:07     INFO - 1287 |nsStyleQuoteValues                    |        8        8|       1        1|
09:36:07     INFO - 1300 |nsSupportsCString                     |       24       24|     101        1|
09:36:07     INFO - 1307 |nsTArray_base                         |        4    13800| 1399986     3450|
09:36:07     INFO - 1311 |nsTextFragment                        |        8       88|    6483       11|
09:36:07     INFO - 1314 |nsTextNode                            |       68      748|    6252       11|
09:36:07     INFO - 1316 |nsThread                              |      200     1000|      52        5|
09:36:07     INFO - 1320 |nsTimer                               |       16       64|    2855        4|
09:36:07     INFO - 1321 |nsTimerImpl                           |       68      272|    2855        4|
09:36:07     INFO - 1331 |nsURIHashKey                          |        8      488|     555       61|
09:36:07     INFO - 1334 |nsUUIDGenerator                       |      168      168|       1        1|
09:36:07     INFO - 1347 |nsVariant                             |       48       48|    1338        1|
09:36:07     INFO - 1353 |nsWeakReference                       |       20      220|     565       11|
09:36:07     INFO - 1378 |nsXBLService                          |       16       16|       1        1|
09:36:07     INFO - 1384 |nsXMLElement                          |       72      504|    4191        7|
09:36:07     INFO - 1387 |nsXPCComponents                       |       56      224|     379        4|
09:36:07     INFO - 1388 |nsXPCComponentsBase                   |       28      112|     379        4|
09:36:07     INFO - 1389 |nsXPCComponents_Classes               |       20       80|     278        4|
09:36:07     INFO - 1393 |nsXPCComponents_ID                    |       20       40|      60        2|
09:36:07     INFO - 1394 |nsXPCComponents_Interfaces            |       24       96|     313        4|
09:36:07     INFO - 1395 |nsXPCComponents_Results               |       20       60|     155        3|
09:36:07     INFO - 1396 |nsXPCComponents_Utils                 |       20       80|     345        4|
09:36:07     INFO - 1399 |nsXPCWrappedJS                        |       60       60|    3624        1|
09:36:07     INFO - 1400 |nsXPCWrappedJSClass                   |       44       44|     529        1|
09:36:07     INFO - 1401 |nsXPConnect                           |       20       20|       1        1|
09:36:07     INFO - 1407 |nsXULPopupManager                     |       76       76|       1        1|
09:36:07     INFO - 1409 |nsXULPrototypeCache                   |      264      264|       1        1|
09:36:07     INFO - 1421 |xpc::CompartmentPrivate               |       44      308|     389        7|
09:36:07     INFO - 1423 |xptiInterfaceInfo                     |       20       40|     902        2|
09:36:07     INFO -
(Reporter)

Updated

2 years ago
Blocks: 1325148
(Assignee)

Comment 1

2 years ago
I can't reproduce this locally, so it's hard to know which test is causing it. Is there a particular reason you filed in this component?
(Assignee)

Updated

2 years ago
Flags: needinfo?(jmaher)
(Reporter)

Comment 2

2 years ago
To be honest I didn't know which component to file it in (this is a huge problem as we don't have owners for tests and tests are not logically put together in manifests).

The last test to run prior to closing the browser is:
toolkit/modules/tests/browser/browser_WebRequest_filtering.js

to me that looked like this is the right component- I do think we need to narrow this down and find which test (or tests) is causing the leak.
Flags: needinfo?(jmaher)
(Reporter)

Comment 3

2 years ago
I did 5 try pushes to narrow down the test range (3 tests per try push):
https://treeherder.mozilla.org/#/jobs?repo=try&author=jmaher@mozilla.com&fromchange=687d5303db0dd05c9d5f298b09ebf03e5a545d33&tochange=8ca9fa2ea7fc495c1f2c790f73bc4d64afda15f0

It will take an hour or so for the results to come in, I will update this bug when I have the test case(s) responsible for the leak.
(Reporter)

Comment 4

2 years ago
ok, splitting this into chunks of 3 didn't reproduce the leak in any of the 5 chunks.
(Reporter)

Comment 5

2 years ago
running all of the 15 tests locally on my win10 box, 2 of the tests cases didn't run solo with --repeat 1:
browser_battery.js
browser_remotePageManager.js

I tried a push with nothing changed to verify I can see the leak on try, and a push with those 2 test cases not enabled:
https://treeherder.mozilla.org/#/jobs?repo=try&author=jmaher@mozilla.com&filter-tier=1&filter-tier=2&filter-tier=3&fromchange=c8c7c7cc84da6ae879e0b8eb50d01a743cd42ee3&tochange=bb0ef5421314b364b385f5a61768b002ce59d159

we will see what the test results look like in another hour or so.
(Reporter)

Comment 6

2 years ago
ok, that didn't work, we still leak- possibly a few more pushes disabling a few tests at a time will get there.
(Reporter)

Comment 7

2 years ago
most likely this leak is in one of these 4 files:
+#[browser_WebNavigation.js]
+#[browser_WebRequest.js]
+#[browser_WebRequest_cookies.js]
+#[browser_WebRequest_filtering.js]

but pushing to try with just these or some combination results in no luck.

This indicates that these are depending on a previous test causing problems.
(Assignee)

Comment 8

2 years ago
OK, I managed to reproduce this locally in chaos mode and get CC logs. It looks like this is probably being caused by GMP requests. I'll try to figure out the rest of the details.
Comment hidden (mozreview-request)
(Assignee)

Comment 10

2 years ago
I gave up poring over refcount logs trying to figure out what's keeping this XMLHttpRequest object alive slightly longer than necessary, and just went with the simpler route of skipping the dummy request when updates are disabled for tests.

Comment 11

2 years ago
mozreview-review
Comment on attachment 8821413 [details]
Bug 1325149: Don't download dummy config when GMP updates are disabled.

https://reviewboard.mozilla.org/r/100706/#review101178
Attachment #8821413 - Flags: review?(rhelmer) → review+
(Assignee)

Comment 12

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/275c894ee97095e64df89b6a575754e4949c21ae
Bug 1325149: Don't download dummy config when GMP updates are disabled. r=rhelmer
(Assignee)

Updated

2 years ago
Assignee: nobody → kmaglione+bmo
(Assignee)

Comment 13

2 years ago
Comment on attachment 8821413 [details]
Bug 1325149: Don't download dummy config when GMP updates are disabled.

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: None. This change should only affect automated tests, in practice. It prevents certain intermittent failures by preventing unnecessary background requests which happen at unpredictable times.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: No verification should be necessary. This change only affects automated tests. 
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Very low-risk.
[Why is the change risky/not risky?]: This change only affects automated tests in which GMP updates are disabled.
[String changes made/needed]: None.
Attachment #8821413 - Flags: approval-mozilla-aurora?

Comment 14

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/275c894ee970
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Shouldn't this bug removed from the whitelist?
Flags: needinfo?(jmaher)
(Reporter)

Comment 16

2 years ago
yes, in the patch that will land this path will be removed from the whitelist- thanks for ensuring this is cleaned up
Flags: needinfo?(jmaher)
[Tracking Requested - why for this release]:
Leak slipped through

This should remain open until it's landed on 52, correct?
Status: RESOLVED → REOPENED
status-firefox51: --- → unaffected
status-firefox52: --- → affected
tracking-firefox52: --- → ?
Resolution: FIXED → ---
(Assignee)

Comment 18

2 years ago
No, uplifts are tracked separately.
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
Comment on attachment 8821413 [details]
Bug 1325149: Don't download dummy config when GMP updates are disabled.

avoid a leak, take in aurora52
Attachment #8821413 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 20

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/ac4036813ff1
status-firefox52: affected → fixed
tracking-firefox52: ? → -

Updated

5 days ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.