Closed
Bug 1325153
Opened 8 years ago
Closed 8 years ago
Convert DoorHangerPopup events to bundle events
Categories
(GeckoView :: General, defect)
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(1 file)
|
41.49 KB,
patch
|
sebastian
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Convert "Doorhanger:Add" and "Doorhanger:Remove" to bundle events. UI events are used because the listener performs UI operations. As part of the refactoring, DoorHangerConfig was refactored to use GeckoBundle, and due to that change, a lot of other doorhanger-related classes also had to be refactored to use GeckoBundle.
Attachment #8820820 -
Flags: review?(s.kaspari)
|
||
Comment 2•8 years ago
|
||
You need to start using Mozreview :-)
|
|
||
Updated•8 years ago
|
Attachment #8820820 -
Flags: review?(s.kaspari) → review+
Pushed by nchen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9fe1fc065c87 Convert DoorHangerPopup events to bundle events; r=sebastian
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9fe1fc065c87
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•5 years ago
|
Target Milestone: Firefox 53 → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•