1325185 - Fix operator precedence in GMPUtils' ToHexString()

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

dmajor pointed out in Bug 1324926 that the precedence of operator >> is greater than operator &. So the code I added to convert a run of bytes to a hex string is wrong.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1325185 - Fix operator precedence in GMPUtils' ToHexString().

Review commit: https://reviewboard.mozilla.org/r/100254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100254/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8820853 [details]
Bug 1325185 - Fix operator precedence in GMPUtils' ToHexString().

https://reviewboard.mozilla.org/r/100254/#review100782

Sorry for missing that before. Thanks for adding a test!

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8820853 [details]
Bug 1325185 - Fix operator precedence in GMPUtils' ToHexString().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/100254/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/839a3dcee4ff
Fix operator precedence in GMPUtils' ToHexString(). r=gerald

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/839a3dcee4ff