If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix operator precedence in GMPUtils' ToHexString()

RESOLVED FIXED in Firefox 53

Status

()

Core
Audio/Video: GMP
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
dmajor pointed out in Bug 1324926 that the precedence of operator >> is greater than operator &. So the code I added to convert a run of bytes to a hex string is wrong.
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8820853 [details]
Bug 1325185 - Fix operator precedence in GMPUtils' ToHexString().

https://reviewboard.mozilla.org/r/100254/#review100782

Sorry for missing that before. Thanks for adding a test!
Attachment #8820853 - Flags: review?(gsquelart) → review+
Comment hidden (mozreview-request)

Comment 4

9 months ago
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/839a3dcee4ff
Fix operator precedence in GMPUtils' ToHexString(). r=gerald

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/839a3dcee4ff
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.